Fix Flaky Organization End to End test by spopelka-dsac · Pull Request #390 · CMS-Enterprise/npd

spopelka-dsac · 2026-02-09T13:17:33Z

module-name: Fix Flaky Organization End to End test

Jira Ticket #N/A

Problem

The organization journey end to end test was failing in github actions, as the test was awaiting the url to change, which was happening before the data were loaded, so the rest of the page was not populated before the rest of the assertions were run.

Solution

Change the expectations in the test so that Playwright is looking for the data to have been loaded, not the URL to have been changed.

Test Plan

The Playwright test should now pass for PR #375

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

* initial search page done * fixed translations * wrote playwright tests * fixing playwright tests * fixed syntax that failed tests * Fixing Search Bugs (#301) * fixed bugs with both pages * [NDH-483] Adding Basic Sort Functionality (#304) * added sort functionality * added practitioner sort support * added sort to all practitioners/organizations page * added sorting tests * fixed spacing * quick test backend tests are failing on my local and im wondering if its doing the same on remote * updated search label, remove duplicate code for SearchContext, fixed spelling mistake, added translations * added translations and fixed pathing * introduced dependency injection and implemented org tranlsations * tracking sort through props * fixing syntax * adding tests * added initial navigation * removing listing pages * fixing layout * making the search page similar to figma * reflecting changes to match search pages to figma * removing unused vars * fixed tests * adding translations * adding additional translations * fixing failing tests * adding prop to match colors across componenent * adding tests * removing faulty test

* created a landing navigation flow playwright test * adding organization journey tests * adding practitioners journey tests * fixing spelling

* NDH-677 clean up address test assertions and fix issue where address use was not present in serialized location data. Also, add address use data in fixture methods for location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * patch org filter by org type and create test for filter set method Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Fix address use filter Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-677 Improve helper method to check if there are results and patch tests that improperly didn't have results Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revise location filter set as well as add tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * lint Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

* created swagger playwright tests * adding regression test to check for faulty param * removing no longer needed timeouts * adding redoc playwright tests * adding regression test to check for faulty param * adding a constants file to reduce maintanence burden

…I are on the thers (#359)

* add all filters to practitioner role filter set except for missing endpoint status and location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add the location filters Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * debug Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests and fix filter params for practionerrole Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * lint Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-539 #comment PR 273 is ready for review Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov> * respond to revisions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add endpoint status column Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-539 add endpoint status column Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * removing the conflict at the source (#321) * Wbprice/the perfect storm (#324) * Update release branch - take 02 (#261) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff * Change trigger for backend tests (#259) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Backend test fix (#260) * Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Blaine Price <william.price@cms.hhs.gov> Co-authored-by: dturner5234 <daniel.r.turner@pilot.cms.gov> Co-authored-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: rmillergv <ross.miller@cms.hhs.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: tspecht-cms <trevor.specht@cms.hhs.gov> Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov> * Add csrf environment variables and logging config (#296) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Sjp/fix 500 errors (#299) * adding test for /fhir page and fixing metadata maybe * fixing the /fhir and /metadata 500s * cleaning up the diff * Sjp/fix 500 errors (#300) * adding test for /fhir page and fixing metadata maybe * fixing the /fhir and /metadata 500s * cleaning up the diff * removing dependency on testserver for metadata endpoint * putting back csrf trusted origins * [NDH-692] Updating provider pk (#308) * Updating provider pk * cleaning up models.py * one more cleanup * update retrieve param naming for clarity * Fixing merge conflicts associated with Big Whammy Release (#318) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff * Change trigger for backend tests (#259) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Backend test fix (#260) * Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * adding migration, updating models.py and updating serializers (#262) * fixing dumb db var name bug (#263) * adding public, npd as the search path (#265) * adding public, npd as the search path * whops, wrong place * deleted the thing * Disable ecs service for gha (#266) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * hardcode npd database name (#267) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-574] Add Playwright GitHub Action (#264) - add optional "make watch-frontend-test-assets" target for live playwright testing - debug Practitioner end-to-end test in CI - update playwright documentation * [NDH-471] Organization listing page with pagination (#269) * initial Organization listing page * add e2e organization tests * update organization e2e test * add end-to-end fixture creation command, seedsystem * make e2e organizations tests rely on data present in system * support pagination on the organization listing page * add faker dependency, sort requirements * update organization listing frontend + e2e tests, fix bugs in pagination * EC2 Instance user data for semi-ephemeral EC2 GitHub Actions Runners (#271) Preconfigure EC2 instance for GitHub Actions with a User Data script --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update weekly refresh token using date modulo'd by 7 rather than milleseconds, which Terraform doesn't support (#274) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update trust policy to read from npd-ops rather than NPD (#275) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Use templatefile() in place of "template_file" (#276) * Update weekly refresh token (#277) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * NDH-572: apply AWS support recs (#258) * Ndh 613 delete test env (#280) * NDH-613: delete test env * delete envs/test directory --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> * deleted clinical org repeatable-migration (#286) * Wbprice/ndh 584 resolve flyway schema already exists error (#281) * update db-migrations FLYWAY_DEFAULT_SCHEMA value --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-639] Add optional SQL query tracing to the backend test suite (#282) * add optional SQL query tracing to the backend test suite * only prepare file logging handler if SQL_TRACING is set * [NDH-479] Basic organization search (#272) * [NDH-479][WIP] Simple organization search * combine search and pagination for /organizations/search * react 19 doesn't need .Provider, swap context nesting * [NDH-618] Developer Page Content Changes (#288) * implemented content changes * adding robust tests * remove infrastructure definitions (#292) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update code.json metadata (#293) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * updated CODEOWNERS file to reflect current staff (#291) * add csrf config and csrf logging config (#298) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Adjusting Aria Levels and Side Bar (#290) * adjusting aria levels and accompanying tests * fixed inconsistent nav bar * [NDH-324] Amendments to Fixtures and Test cases (#256) * check all entries in filter assertions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * address remaining comments Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create fixtures module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add another code to test data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * format code with ruff Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * patch location fixture Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix address use bug in serializer Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create seperate create_address method Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create non nurse records Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rename test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * change serializer for otherIDs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * verify length in test_list_filter_by_npi_specific Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rewrite the address filter to check to see if search appears in address when transformed into a string Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * check all addresses in tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix organization fixture module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports in seedsystem Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revise for pr review Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * unused import Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * debug remove print Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * apply revision to general id filter Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * resolve conflict in markdown Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix typo causing test failure Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-641] Add Snyk GitHub Workflow (#284) * Create snyk.yml * Update snyk.yml * upgrade deps Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * added npm override to fix transitive dependency --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> * backfilling hotfixes into main (#302) * fixing failing snyk status (#306) * Fixes in README.md (#307) Fix misspelled word and link in the repo structure section. * replicating changes off of main (#311) * upgraded vulnerable package (#312) * updated sytnax to fix string bug] (#315) --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Blaine Price <william.price@cms.hhs.gov> Co-authored-by: dturner5234 <daniel.r.turner@pilot.cms.gov> Co-authored-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Adam Bachman <adam.bachman@cms.hhs.gov> Co-authored-by: rmillergv <ross.miller@cms.hhs.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: tspecht-cms <trevor.specht@cms.hhs.gov> Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: sman-dsac <sunil.manchikanti1@cms.hhs.gov> * Fixing Additional Merge Conflicts for Big Whammy Release (#319) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff * Change trigger for backend tests (#259) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Backend test fix (#260) * Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * adding migration, updating models.py and updating serializers (#262) * fixing dumb db var name bug (#263) * adding public, npd as the search path (#265) * adding public, npd as the search path * whops, wrong place * deleted the thing * Disable ecs service for gha (#266) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * hardcode npd database name (#267) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-574] Add Playwright GitHub Action (#264) - add optional "make watch-frontend-test-assets" target for live playwright testing - debug Practitioner end-to-end test in CI - update playwright documentation * [NDH-471] Organization listing page with pagination (#269) * initial Organization listing page * add e2e organization tests * update organization e2e test * add end-to-end fixture creation command, seedsystem * make e2e organizations tests rely on data present in system * support pagination on the organization listing page * add faker dependency, sort requirements * update organization listing frontend + e2e tests, fix bugs in pagination * EC2 Instance user data for semi-ephemeral EC2 GitHub Actions Runners (#271) Preconfigure EC2 instance for GitHub Actions with a User Data script --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update weekly refresh token using date modulo'd by 7 rather than milleseconds, which Terraform doesn't support (#274) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update trust policy to read from npd-ops rather than NPD (#275) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Use templatefile() in place of "template_file" (#276) * Update weekly refresh token (#277) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * NDH-572: apply AWS support recs (#258) * Ndh 613 delete test env (#280) * NDH-613: delete test env * delete envs/test directory --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> * deleted clinical org repeatable-migration (#286) * Wbprice/ndh 584 resolve flyway schema already exists error (#281) * update db-migrations FLYWAY_DEFAULT_SCHEMA value --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-639] Add optional SQL query tracing to the backend test suite (#282) * add optional SQL query tracing to the backend test suite * only prepare file logging handler if SQL_TRACING is set * [NDH-479] Basic organization search (#272) * [NDH-479][WIP] Simple organization search * combine search and pagination for /organizations/search * react 19 doesn't need .Provider, swap context nesting * [NDH-618] Developer Page Content Changes (#288) * implemented content changes * adding robust tests * remove infrastructure definitions (#292) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update code.json metadata (#293) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * updated CODEOWNERS file to reflect current staff (#291) * add csrf config and csrf logging config (#298) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Adjusting Aria Levels and Side Bar (#290) * adjusting aria levels and accompanying tests * fixed inconsistent nav bar * [NDH-324] Amendments to Fixtures and Test cases (#256) * check all entries in filter assertions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * address remaining comments Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create fixtures module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add another code to test data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * format code with ruff Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * patch location fixture Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix address use bug in serializer Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create seperate create_address method Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create non nurse records Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rename test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * change serializer for otherIDs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * verify length in test_list_filter_by_npi_specific Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rewrite the address filter to check to see if search appears in address when transformed into a string Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * check all addresses in tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix organization fixture module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports in seedsystem Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revise for pr review Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * unused import Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * debug remove print Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * apply revision to general id filter Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * resolve conflict in markdown Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix typo causing test failure Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-641] Add Snyk GitHub Workflow (#284) * Create snyk.yml * Update snyk.yml * upgrade deps Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * added npm override to fix transitive dependency --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> * backfilling hotfixes into main (#302) * fixing failing snyk status (#306) * Fixes in README.md (#307) Fix misspelled word and link in the repo structure section. * replicating changes off of main (#311) * upgraded vulnerable package (#312) * updated sytnax to fix string bug] (#315) * adding workflow that allows for automated sync from release to main (#313) --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Blaine Price <william.price@cms.hhs.gov> Co-authored-by: dturner5234 <daniel.r.turner@pilot.cms.gov> Co-authored-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Adam Bachman <adam.bachman@cms.hhs.gov> Co-authored-by: rmillergv <ross.miller@cms.hhs.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: tspecht-cms <trevor.specht@cms.hhs.gov> Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: sman-dsac <sunil.manchikanti1@cms.hhs.gov> * Sjp/another merge try (#320) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-gi…

* removing the conflict at the source (#321) * Wbprice/the perfect storm (#324) * Update release branch - take 02 (#261) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff * Change trigger for backend tests (#259) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Backend test fix (#260) * Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Blaine Price <william.price@cms.hhs.gov> Co-authored-by: dturner5234 <daniel.r.turner@pilot.cms.gov> Co-authored-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: rmillergv <ross.miller@cms.hhs.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: tspecht-cms <trevor.specht@cms.hhs.gov> Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov> * Add csrf environment variables and logging config (#296) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Sjp/fix 500 errors (#299) * adding test for /fhir page and fixing metadata maybe * fixing the /fhir and /metadata 500s * cleaning up the diff * Sjp/fix 500 errors (#300) * adding test for /fhir page and fixing metadata maybe * fixing the /fhir and /metadata 500s * cleaning up the diff * removing dependency on testserver for metadata endpoint * putting back csrf trusted origins * [NDH-692] Updating provider pk (#308) * Updating provider pk * cleaning up models.py * one more cleanup * update retrieve param naming for clarity * Fixing merge conflicts associated with Big Whammy Release (#318) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff * Change trigger for backend tests (#259) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Backend test fix (#260) * Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * adding migration, updating models.py and updating serializers (#262) * fixing dumb db var name bug (#263) * adding public, npd as the search path (#265) * adding public, npd as the search path * whops, wrong place * deleted the thing * Disable ecs service for gha (#266) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * hardcode npd database name (#267) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-574] Add Playwright GitHub Action (#264) - add optional "make watch-frontend-test-assets" target for live playwright testing - debug Practitioner end-to-end test in CI - update playwright documentation * [NDH-471] Organization listing page with pagination (#269) * initial Organization listing page * add e2e organization tests * update organization e2e test * add end-to-end fixture creation command, seedsystem * make e2e organizations tests rely on data present in system * support pagination on the organization listing page * add faker dependency, sort requirements * update organization listing frontend + e2e tests, fix bugs in pagination * EC2 Instance user data for semi-ephemeral EC2 GitHub Actions Runners (#271) Preconfigure EC2 instance for GitHub Actions with a User Data script --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update weekly refresh token using date modulo'd by 7 rather than milleseconds, which Terraform doesn't support (#274) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update trust policy to read from npd-ops rather than NPD (#275) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Use templatefile() in place of "template_file" (#276) * Update weekly refresh token (#277) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * NDH-572: apply AWS support recs (#258) * Ndh 613 delete test env (#280) * NDH-613: delete test env * delete envs/test directory --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> * deleted clinical org repeatable-migration (#286) * Wbprice/ndh 584 resolve flyway schema already exists error (#281) * update db-migrations FLYWAY_DEFAULT_SCHEMA value --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-639] Add optional SQL query tracing to the backend test suite (#282) * add optional SQL query tracing to the backend test suite * only prepare file logging handler if SQL_TRACING is set * [NDH-479] Basic organization search (#272) * [NDH-479][WIP] Simple organization search * combine search and pagination for /organizations/search * react 19 doesn't need .Provider, swap context nesting * [NDH-618] Developer Page Content Changes (#288) * implemented content changes * adding robust tests * remove infrastructure definitions (#292) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update code.json metadata (#293) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * updated CODEOWNERS file to reflect current staff (#291) * add csrf config and csrf logging config (#298) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Adjusting Aria Levels and Side Bar (#290) * adjusting aria levels and accompanying tests * fixed inconsistent nav bar * [NDH-324] Amendments to Fixtures and Test cases (#256) * check all entries in filter assertions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * address remaining comments Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create fixtures module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add another code to test data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * format code with ruff Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * patch location fixture Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix address use bug in serializer Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create seperate create_address method Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create non nurse records Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rename test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * change serializer for otherIDs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * verify length in test_list_filter_by_npi_specific Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rewrite the address filter to check to see if search appears in address when transformed into a string Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * check all addresses in tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix organization fixture module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports in seedsystem Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revise for pr review Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * unused import Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * debug remove print Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * apply revision to general id filter Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * resolve conflict in markdown Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix typo causing test failure Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-641] Add Snyk GitHub Workflow (#284) * Create snyk.yml * Update snyk.yml * upgrade deps Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * added npm override to fix transitive dependency --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> * backfilling hotfixes into main (#302) * fixing failing snyk status (#306) * Fixes in README.md (#307) Fix misspelled word and link in the repo structure section. * replicating changes off of main (#311) * upgraded vulnerable package (#312) * updated sytnax to fix string bug] (#315) --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Blaine Price <william.price@cms.hhs.gov> Co-authored-by: dturner5234 <daniel.r.turner@pilot.cms.gov> Co-authored-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Adam Bachman <adam.bachman@cms.hhs.gov> Co-authored-by: rmillergv <ross.miller@cms.hhs.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: tspecht-cms <trevor.specht@cms.hhs.gov> Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: sman-dsac <sunil.manchikanti1@cms.hhs.gov> * Fixing Additional Merge Conflicts for Big Whammy Release (#319) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * adding parent_org and associated test * fixing broken tests * linting fixes * fixing accidental package-lock stuff * Change trigger for backend tests (#259) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Backend test fix (#260) * Change trigger for backend tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove upstream reporting tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * adding migration, updating models.py and updating serializers (#262) * fixing dumb db var name bug (#263) * adding public, npd as the search path (#265) * adding public, npd as the search path * whops, wrong place * deleted the thing * Disable ecs service for gha (#266) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * hardcode npd database name (#267) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-574] Add Playwright GitHub Action (#264) - add optional "make watch-frontend-test-assets" target for live playwright testing - debug Practitioner end-to-end test in CI - update playwright documentation * [NDH-471] Organization listing page with pagination (#269) * initial Organization listing page * add e2e organization tests * update organization e2e test * add end-to-end fixture creation command, seedsystem * make e2e organizations tests rely on data present in system * support pagination on the organization listing page * add faker dependency, sort requirements * update organization listing frontend + e2e tests, fix bugs in pagination * EC2 Instance user data for semi-ephemeral EC2 GitHub Actions Runners (#271) Preconfigure EC2 instance for GitHub Actions with a User Data script --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update weekly refresh token using date modulo'd by 7 rather than milleseconds, which Terraform doesn't support (#274) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update trust policy to read from npd-ops rather than NPD (#275) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Use templatefile() in place of "template_file" (#276) * Update weekly refresh token (#277) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * NDH-572: apply AWS support recs (#258) * Ndh 613 delete test env (#280) * NDH-613: delete test env * delete envs/test directory --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> * deleted clinical org repeatable-migration (#286) * Wbprice/ndh 584 resolve flyway schema already exists error (#281) * update db-migrations FLYWAY_DEFAULT_SCHEMA value --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-639] Add optional SQL query tracing to the backend test suite (#282) * add optional SQL query tracing to the backend test suite * only prepare file logging handler if SQL_TRACING is set * [NDH-479] Basic organization search (#272) * [NDH-479][WIP] Simple organization search * combine search and pagination for /organizations/search * react 19 doesn't need .Provider, swap context nesting * [NDH-618] Developer Page Content Changes (#288) * implemented content changes * adding robust tests * remove infrastructure definitions (#292) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update code.json metadata (#293) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * updated CODEOWNERS file to reflect current staff (#291) * add csrf config and csrf logging config (#298) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Adjusting Aria Levels and Side Bar (#290) * adjusting aria levels and accompanying tests * fixed inconsistent nav bar * [NDH-324] Amendments to Fixtures and Test cases (#256) * check all entries in filter assertions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * address remaining comments Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create fixtures module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add another code to test data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * format code with ruff Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * patch location fixture Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix address use bug in serializer Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create seperate create_address method Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * create non nurse records Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rename test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * change serializer for otherIDs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * verify length in test_list_filter_by_npi_specific Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * rewrite the address filter to check to see if search appears in address when transformed into a string Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * check all addresses in tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix organization fixture module Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix imports in seedsystem Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revise for pr review Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * unused import Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * debug remove print Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * apply revision to general id filter Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * resolve conflict in markdown Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix typo causing test failure Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-641] Add Snyk GitHub Workflow (#284) * Create snyk.yml * Update snyk.yml * upgrade deps Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * added npm override to fix transitive dependency --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> * backfilling hotfixes into main (#302) * fixing failing snyk status (#306) * Fixes in README.md (#307) Fix misspelled word and link in the repo structure section. * replicating changes off of main (#311) * upgraded vulnerable package (#312) * updated sytnax to fix string bug] (#315) * adding workflow that allows for automated sync from release to main (#313) --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Blaine Price <william.price@cms.hhs.gov> Co-authored-by: dturner5234 <daniel.r.turner@pilot.cms.gov> Co-authored-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Adam Bachman <adam.bachman@cms.hhs.gov> Co-authored-by: rmillergv <ross.miller@cms.hhs.gov> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: tspecht-cms <trevor.specht@cms.hhs.gov> Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Sachin Panayil <sachinpanayil01@gmail.com> Co-authored-by: sman-dsac <sunil.manchikanti1@cms.hhs.gov> * Sjp/another merge try (#320) * add missing file (#209) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update load balancer listener config, update allowed hosts in django (#210) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * update allowed hosts (#211) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * remove strategy page redirect - because it is difficult to read and reason about - the strategy of asking terraform to hop from one load balancer listener to another on the fly is brittle and failed out on me during a prod deploy * clean up remaining redirect to strategy page config * terraform fmt * Wbprice/internal dns configuration (#213) * create internal dns configuration to be imported into infoblocks --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Remove sandbox terraform definitions and github actions workflows (#214) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * specify storage autoscaling limits (#215) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-303] Implement Custom Sorting in FHIR API (#195) * add custom sorting to endpoint view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add custom sorting for practitioner role view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add location view set Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix errors Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for custom sorting functionality Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * conform to proper parameter name in ticket Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add sort parameter to swagger docs Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Use an alias to describe directory domain (#217) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-446] ensure login header, footer, and body are responsive on mobile (#216) * ensure header title does not wrap at desktop size (#218) * ensure header title does not wrap at desktop size * handle logo margin at <desktop >mobile sizes * [NDH-399] Introducing feature flags! (#193) * [NDH-399] Introducing feature flags! * move feature flags under frontend settings * finish FeatureFlag support in frontend, including examples of testing * finish frontend feature flag setup work * remove 'localhost:8000' from ALLOWED_HOSTS * fix typo in comment * add repeatable seed migrations for local development * restore existing migration from main * fix typo in django_migrations readme * fix test fixture creation for feature flag condition * added ross miller to the team in COMMUNITY.md (#222) * added ross miller to the team in COMMUNITY.md * Address review feedback for changes to COMMUNITY.md * updating contributors list (#224) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * updating contributors list (#225) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Provision test resources (#219) * test, not impl * add test env * update test image tf_vars * bring in dns module * update default images for services --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-401]: Refactored tests.py into different suites (#223) * refactored tests.py into different suites * reverted our init re exports in filters * removed some comments * removed redundant helper * added requested changes * fix: address sorting change test breakage for LocationViewSetTestCase (#221) * Update internal domains (#226) * For internal domains, update 'directory' to read 'cnpd' now that a FISMA code has been assigned * Update docs --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * bump storage space in dev etl rds (#228) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * removed browsableAPI renderer (#230) * [NDH-359] Establish code quality baseline for Python and Typescript (#173) * [NDH-359] Add precommit-config including auto-formatting * ruff format everything in backend/ * add Python linting to backend-test CI workflow * add backend/Makefile commands for installing ruff and pre-commit and running lint + format * update documentation * re-enable dms (#229) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update CODEOWNERS file (#231) * update CODEOWNERS file to describe notification and reviewer expectations * rename CODEOWNERS file, swap comment syntax * Introduce Playwright for end-to-end-testing (#227) * introducing playwright for end-to-end testing of the NPD application * make sure the backend knows when it is running as a test-server * allow frontend dev server to use VITE_API_BASE_URL as proxy target * make frontend a little more testable * ensure backend works when TESTING is not in env * npm install insists * add Playwright running notes * backend `make` commands necessary for playwright and useful for development * update playwright documentation * Update code.json metadata (#235) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CI Runner Out of Space Errors (#232) - Increase default size of CI instance from 31G (default) to 250G - Update documentation to describe how to increase size of volumes backing the root volume where the CI runner works Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-398] Organization details screen - initial work (#198) * [NDH-398] introduce @tanstack/react-query, start shaping the Organization lookup page * ensure Organization page renders in test with feature flags obeyed * fix inverse feature flag logic * npm install inside container keeps fiddling with package-lock.json * set VITE_API_BASE_URL in GitHub Action frontend test workflow * add basic Organization page sections, update styles * put update your details alert inside feature flag block * Fixing Failing Gitleaks Action (#238) * added false positive fingerprints to .gitleaksignore * missed two of them * [NDH-448] Modify Django Tests to Use setUpTestData Methods Instead of Sample Data SQL (#234) * add flyway option to exclude sample data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * First draft of creating fixture and factory test data helpers for implementation with tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move fixtures file anfter moving in test refactor changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get some of the fixtures working and patch overwrite in compose-test Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * bug fixes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * need to insert all required data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * now have working tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * make sure to use lists when it makes sense Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * fix unused variables Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add proper sorting test back Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * self-referencing rules for etl and fhir api db security groups (#233) * self-referencing for etl and fhir api db security groups * update dms to target npd_staging * Change task to full-load and CDC * revert stop task setting * "MaxFullLoadSubTasks": 2 for testing * remove local.multi_az reference; remove try statements --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> * Automate export of FHIR API schema to Typescript (#239) * automate export of FHIR API schema to Typescript * drop old types file * update test fixtures with new API types * http -> https redirect (#245) - creates http -> https redirect for directory.cms.gov (prod) - updates production domain names for directory.cms.gov and api.directory.cms.gov in domains module Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * correct typo in lvextend instructions (#244) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-424] Unified project tooling (#237) * [NDH-424] add bin/npr script to the project * drop make commands from npr * consolidate to a single docker compose configuration file setup * move project-central make commands to a top-level Makefile * don't run playwright host commands with bin/npr * ensure playwright can correctly start test-server, finish Makefile .PHONY entries * drop backend/docker-compose.yml reference from bin/npr * use bin/npr in make tasks whenever possible, rename test-fast to test-backend, add test-frontend * update GHA test jobs to match new structure * make and bin/npr should use compose.test.yml to run db migrations for test-setup * update documentation, ensure all make and npr commands work * update note on frontend dependencies * do not include flyway local_dev in compose.test.yml * Organization component test should wait for feature flag components to render (#246) * NDH-520: set up prod-test env (#248) * NDH-520: set up prod-test env * add prod-test map to domains module * name change to stay under 32 chars * apply name change * apply name change in all the places * update readme with prod-test info * more dagster -> etl naming change --------- Co-authored-by: tspecht-cms <trevor.specht@hhs.cms.gov> Co-authored-by: Blaine Price <1wbprice@gmail.com> * [NDH-553] Basic React error pages (#249) * [NDH-552] move default user creation to django command, add auth helper for e2e testing * [NDH-553] add basic ErrorBoundary and NotFound pages * add not_found end-to-end test * [NDH-324] Improve Practitioner Test Assertions (#250) * add equal checks to filter tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add check for nucc codes in test practitioner Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add functionality to create fixture data with practitioners tied to location Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * get all address related tests working Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * [NDH-397] Initial Practitioner page (#240) - generic API support updates - end-to-end test * [NDH-476]: Organization Detail MVP (#242) * used translation files to display text * fixed definitions * added about section * added contact section * implemented identifiers section * removed bad file * refactored into new type framework * added some tests * removed some tests * adding requested changes * [NDH-559] provider_directory.tests.test_views should not rely on file system (#252) * Wbprice/self hosted runner containers (#251) * exploratory work on self-hosted github runners running in ecs, adapted from https://www.warpbuild.com/blog/self-hosting-github-actions\#method-2-using-ecs-elastic-container-service --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * Update internal route53 configuration (#253) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * we want an internal domain for the directory in prod-test (#255) Co-authored-by: Blaine Price <william.price@cms.hhs.gov> * [NDH-477]: Practitioner Page MVP (#254) * contact layout section + translations implemented * created baseline about and contact * implemted identifiers section * refactored selectors into a Presenter class * added more translations * added more translations that i forgor * some tweaks to support working with real data (#206) * some tweaks to support working with real data * reverting settings changes * fix failing test and remove print statement * tweaks * tweaks * …

…e lat/lon (#362)

…r organizations Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

…#366) Bumps the pip group with 1 update in the /backend directory: [python-multipart](https://github.com/Kludex/python-multipart). Updates `python-multipart` from 0.0.20 to 0.0.22 - [Release notes](https://github.com/Kludex/python-multipart/releases) - [Changelog](https://github.com/Kludex/python-multipart/blob/master/CHANGELOG.md) - [Commits](Kludex/python-multipart@0.0.20...0.0.22) --- updated-dependencies: - dependency-name: python-multipart dependency-version: 0.0.22 dependency-type: direct:production dependency-group: pip ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

Bumps the npm_and_yarn group with 3 updates in the /frontend directory: [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite), [glob](https://github.com/isaacs/node-glob) and [js-yaml](https://github.com/nodeca/js-yaml). Updates `vite` from 7.1.5 to 7.3.1 - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v7.3.1/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.3.1/packages/vite) Updates `glob` from 10.4.5 to 10.5.0 - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v10.4.5...v10.5.0) Updates `js-yaml` from 4.1.0 to 4.1.1 - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.0...4.1.1) --- updated-dependencies: - dependency-name: vite dependency-version: 7.3.1 dependency-type: direct:development dependency-group: npm_and_yarn - dependency-name: glob dependency-version: 10.5.0 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: js-yaml dependency-version: 4.1.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update container to start with gunicorn instead of dev server add command to compose to override container and run dev server for local environments * get static file hosting working using whitenoise * cleanup, document static file handling practices --------- Co-authored-by: Dan Turner <daniel.turner1@cms.hhs.gov> Co-authored-by: Blaine Price <william.price@cms.hhs.gov>

Update COMMUNITY.md to reflect new team structure

…o API DB (#241) * first bit * adding more code * got all the tables * more tweaks * more tweaks * now just need to ensure the inserts work * renaming file * more changes * more tweaks * removing playwright files * tweaking credentials * sjp/halloween-csvs * commenting provider_to_credential * Adding explanatory content * clear all outputs * sjp/halloween-csvs * just in case * renaming V13 migration to V14 * some tweaks for ids * Delete flyway/docker-compose.yml * removing comments * clear outputs * uncommenting one line --------- Co-authored-by: Blaine Price <1wbprice@gmail.com>

* work so far * refactoring views

* linting changes * adding check to confirm expected name * adding requested changes --------- Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

* NDH-797 add spellcheck workflow that uses reviewdog and typos tool Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * wrong action Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * spelling Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revisions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * reverse spelling Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov> * revisions Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov> * ignore flyway files Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov> Co-authored-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>

* set up organization affiliation views and start working on relevant serializer Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * organization affiliation serializer rough draft Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * use new serializer for organization affiliation Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add basic tests and fix issues found by it Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * change name of viewset Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add logic to support querying Orgs and EHRVendors at the same time Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for ehr vendors in organization endpoint Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add tests for org affilation endpoint Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * format Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * change caption assertion Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * debug playwright Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove old file Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * adding sample data (#294) * playwright assertions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * playwright assertions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * 7 pages of data Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * render Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * undo Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * use genReference instead of Reference() Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove orgaffil sorts and filters Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revisions to org affil serialization Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-278 revisions to org affil serialization Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revert test changes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * failing tests after merge Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * linting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove search filter Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * remove comments Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * linting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add filter sets back to organization Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revisions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * move queryset definitions for organizationaffilliation Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * improve org affil tests Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * Run ruff formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * revisions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

…rned data (#378) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

…entials (#369) * creating supporting flyway migration to create npd_readonly user * added default values so tests run * added requested changes * updating var names to reflect terraform * updating user names * updating compose.test.yml --------- Co-authored-by: Blaine Price <1wbprice@gmail.com>

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

* added practitioner paging tests * adding organization tests * adding user journey tests --------- Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

* add load tester user migration --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov>

* created Results component * fixing linting * added SearchBar component * fixing failing linting test due to import pathing

…nt-tests' into sjp/fix_flaky_e2e_test

IsaacMilarky and others added 30 commits January 20, 2026 20:18

NDH-676 clean up test assertion initial (#310)

04a1a6a

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

[NDH-749] End to End Playwright Tests for Frontend (#355)

649e9eb

* created a landing navigation flow playwright test * adding organization journey tests * adding practitioners journey tests * fixing spelling

specifying upgraded version of lodash (#357)

9325d2e

removing infrastucture codeowners entry and ensuring that Blaine and …

d364a59

…I are on the thers (#359)

increase django connection pool size (#361)

0cb3e75

updating location serializer to account for addresses that do not hav…

9c4c2e3

…e lat/lon (#362)

Update CODEOWNERS (#364)

14175ae

Update README.md to emphasize project setup and development (#365)

18e08ea

NDH-679 Make name search for orgs be less strict and improve tests fo…

6685427

…r organizations Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

Merge branch 'main' into NDH-678-improve-test-assertions-for-org-tests

967e229

NDH-678 add improvements to address checks

c23486e

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

Merge branch 'main' into NDH-678-improve-test-assertions-for-org-tests

c5f4811

updating links to new repo path (#370)

21d26d4

Update COMMUNITY.md (#371)

bd59e07

Update COMMUNITY.md to reflect new team structure

Reduce duplication in the view queryset code (#377)

c4ba8a9

* work so far * refactoring views

[NDH-776] Fix Frontend Unit Test Warnings (#374)

a3bdac0

* linting changes * adding check to confirm expected name * adding requested changes --------- Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

NDH-679 Add checks to make sure that filter parameters match the retu…

f843faf

…rned data (#378) Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

Merge branch 'main' into NDH-678-improve-test-assertions-for-org-tests

8bc555e

IsaacMilarky and others added 13 commits February 4, 2026 10:28

add aliases

fca74bf

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

NDH-678 Implement revisions

3bc7188

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

NDH-678 add explicit check for broad name check

deb6843

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

NDH-678 formatting

98a628f

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

Upgrade django version (#382)

97ddfd4

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>

[NDH-770] Adding Pagination Playwright Tests (#380)

ab1e07b

* added practitioner paging tests * adding organization tests * adding user journey tests --------- Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>

moved the env placeholder to compose.yml (#384)

7c5bdd4

Merge branch 'main' into NDH-678-improve-test-assertions-for-org-tests

7cfcada

Wbprice/ndh 812 load tester user migration (#383)

8eca420

* add load tester user migration --------- Co-authored-by: Blaine Price <william.price@cms.hhs.gov>

Merge branch 'main' into NDH-678-improve-test-assertions-for-org-tests

e52042e

[NDH-803] Modularizing Frontend into Components (#381)

a18caf7

* created Results component * fixing linting * added SearchBar component * fixing failing linting test due to import pathing

Merge branch 'main' into NDH-678-improve-test-assertions-for-org-tests

df3824e

fixing flaky organization end to end test

eff2f4f

spopelka-dsac requested review from IsaacMilarky and sachin-panayil as code owners February 9, 2026 13:17

Merge branch 'isaacmilarky/NDH-676-improve-test-assertions-for-endpoi…

62f8aa8

…nt-tests' into sjp/fix_flaky_e2e_test

spopelka-dsac closed this Feb 9, 2026

spopelka-dsac deleted the sjp/fix_flaky_e2e_test branch February 9, 2026 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fix Flaky Organization End to End test#390

Fix Flaky Organization End to End test#390
spopelka-dsac wants to merge 44 commits intoisaacmilarky/NDH-676-improve-test-assertions-for-endpoint-testsfrom
sjp/fix_flaky_e2e_test

spopelka-dsac commented Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

spopelka-dsac commented Feb 9, 2026

module-name: Fix Flaky Organization End to End test

Jira Ticket #N/A

Problem

Solution

Test Plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants