more response assertions#392
Merged
spopelka-dsac merged 1 commit intoNDH-678-improve-test-assertions-for-org-testsfrom Feb 9, 2026
Merged
more response assertions#392spopelka-dsac merged 1 commit intoNDH-678-improve-test-assertions-for-org-testsfrom
spopelka-dsac merged 1 commit intoNDH-678-improve-test-assertions-for-org-testsfrom
Conversation
spopelka-dsac
merged commit 8e22b83
into
NDH-678-improve-test-assertions-for-org-tests
7 checks passed
spopelka-dsac
added a commit
that referenced
this pull request
Feb 9, 2026
* NDH-679 Make name search for orgs be less strict and improve tests for organizations Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-678 add improvements to address checks Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * add aliases Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-678 Implement revisions Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-678 add explicit check for broad name check Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * NDH-678 formatting Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> * awaiting response (#391) * more response assertions (#392) * Sjp/more response awaits (#393) * more response assertions * making the response urls more explicit * updating orgname sort field in frontend (#394) --------- Signed-off-by: Isaac Milarsky <imilarsky@gmail.com> Co-authored-by: Blaine Price <1wbprice@gmail.com> Co-authored-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov> Co-authored-by: Sachin Panayil <79382140+sachin-panayil@users.noreply.github.com> Co-authored-by: Sarah Popelka <sarah.popelka1@cms.hhs.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module-name: Fix Flaky Organization End to End test
Jira Ticket #N/A
Problem
The organization journey end to end test needed more response expectations..
Solution
Change the expectations in the test so that Playwright is looking for the data to have been loaded, not the URL to have been changed.
Test Plan
The Playwright test should now pass for PR #375