BFD-4154: Carrier/DME Mappings for V3 - #2761
Merged
Merged
Conversation
alex-dzeda
marked this pull request as ready for review
July 28, 2025 15:22
alex-dzeda
requested review from
aschey-forpeople,
malessi and
mjburling
as code owners
July 28, 2025 15:22
aschey-forpeople
approved these changes
Jul 28, 2025
MahiFentaye
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4154
What Does This PR Do?
This PR adds Carrier/DME Mappings for v3, as well as updates sample data.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
There will be some upcoming reorganization of files once we tightly couple the BFD output/sample data to the validator. FML seems to variably handle the existence of fields (eg "src.FIELD as X" should only execute the statement after the arrow if the variable is present. It appears that is handled differently depending on if something is in an array or a single object), but this is called out in comments in areas it originally resulted in throwing errors.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Running compile_resources against the carrier and DME samples works as expected, with no unexpected errors (the data absent reason one is purposeful).