Skip to content

BFD-4167: Initial IDR pipeline terraservice and fixes for prod data - #2771

Merged
aschey-forpeople merged 36 commits into
masterfrom
BFD-4167__idr-pipeline-terraservice
Aug 12, 2025
Merged

BFD-4167: Initial IDR pipeline terraservice and fixes for prod data#2771
aschey-forpeople merged 36 commits into
masterfrom
BFD-4167__idr-pipeline-terraservice

Conversation

@aschey-forpeople

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BFD-4167

What Does This PR Do?

  • Adds initial terraservice for the IDR pipeline
  • Fixes some problems with the data model (typos in columns, optional fields)
  • Updates logic for progress tracking in the pipeline to better handle partial loads that failed
  • Updates Snowflake auth to use private keys
  • Adds an environment variable to limit the volume of claims loaded for historical data
    • this is temporary, the strategy for loading historical data will change later

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

Loaded IDR data in prod

alex-dzeda
alex-dzeda previously approved these changes Aug 7, 2025
Comment thread apps/bfd-pipeline/bfd-pipeline-idr/model.py
brick-green
brick-green previously approved these changes Aug 11, 2025

@brick-green brick-green left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few thoughts

Comment thread apps/bfd-pipeline/bfd-pipeline-idr/bfd.sql
Comment thread apps/bfd-pipeline/bfd-pipeline-idr/extractor.py
Comment thread apps/bfd-pipeline/bfd-pipeline-idr/extractor.py

@brick-green brick-green left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy with the replies. Resolved conversations

Comment thread ops/services/04-idr-pipeline/main.tf
@aschey-forpeople
aschey-forpeople added this pull request to the merge queue Aug 12, 2025
Merged via the queue into master with commit 9c22d1e Aug 12, 2025
10 checks passed
@aschey-forpeople
aschey-forpeople deleted the BFD-4167__idr-pipeline-terraservice branch August 12, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants