Skip to content

BFD-4239: Combine claim lines, procedures, and values - #2777

Merged
aschey-forpeople merged 22 commits into
masterfrom
BFD-4239
Aug 18, 2025
Merged

BFD-4239: Combine claim lines, procedures, and values#2777
aschey-forpeople merged 22 commits into
masterfrom
BFD-4239

Conversation

@aschey-forpeople

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BFD-4239

What Does This PR Do?

  • Combines the clm_line, clm_prod, and clm_val tables into a single table that's unique by the combination of clm_uniq_id + bfd_row_id
    • See comment in the model class for how/why this works
  • Updates the server to use the new table
  • Changes the query to load the list of claim IDs to perform a separate raw query first
    • This is necessary because JPA doesn't support limit/offset in JPQL queries.

The change here yields a notable performance increase in the API from 1-2 seconds down to 0.1-0.3 seconds.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

Re-ingested claim line items in prod. Ran the API against prod data.

Base automatically changed from BFD-4167__idr-pipeline-terraservice to master August 12, 2025 19:00
brick-green
brick-green previously approved these changes Aug 14, 2025
@aschey-forpeople
aschey-forpeople added this pull request to the merge queue Aug 18, 2025
Merged via the queue into master with commit f26c422 Aug 18, 2025
10 checks passed
@aschey-forpeople
aschey-forpeople deleted the BFD-4239 branch August 18, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants