Skip to content

BFD-4267: Use negative values for synthetic data + some logging fixes - #2788

Merged
aschey-forpeople merged 4 commits into
masterfrom
BFD-4267
Sep 2, 2025
Merged

BFD-4267: Use negative values for synthetic data + some logging fixes#2788
aschey-forpeople merged 4 commits into
masterfrom
BFD-4267

Conversation

@aschey-forpeople

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BFD-4267

What Does This PR Do?

  • Updates synthetic data generator to always use negative values for bene_sk and clm_uniq_id
    • This makes it easier to keep track of which data is synthetic when we mix synthetic and real data together
  • Adds new parameters to the data generator to randomize the number of claims per patient
  • A few fixes for the data generator when using the benes-sandbox.csv file
    • Adds additional CI tests to ensure that the data generator works with this file
  • Logging improvements for MDC values and when an error is redirected to the /error controller
  • Fixes status code for an unauthorized request to return 401 instead of 400 - I think I accidentally changed this a bit ago

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

tests

Comment thread apps/bfd-pipeline/bfd-pipeline-idr/loader.py
Comment thread ops/services/04-server-ng/service.tf
Comment thread apps/bfd-model-idr/claims_generator.py
Comment thread apps/bfd-model-idr/Benes-Sandbox.csv Outdated
brick-green
brick-green previously approved these changes Aug 29, 2025

@brick-green brick-green left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one comment

Comment thread apps/bfd-model-idr/claims_generator.py
@aschey-forpeople
aschey-forpeople added this pull request to the merge queue Sep 2, 2025
Merged via the queue into master with commit 7091441 Sep 2, 2025
11 checks passed
@aschey-forpeople
aschey-forpeople deleted the BFD-4267 branch September 2, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants