Skip to content

BFD-4248: Send Release and Deploy BFD Workflow run status updates to Slack - #3067

Merged
jonathan-cantu-icf merged 30 commits into
masterfrom
feature/BFD-4248_GitHub-BuildAndDeploy-Slack-Notification
Apr 30, 2026
Merged

BFD-4248: Send Release and Deploy BFD Workflow run status updates to Slack#3067
jonathan-cantu-icf merged 30 commits into
masterfrom
feature/BFD-4248_GitHub-BuildAndDeploy-Slack-Notification

Conversation

@jonathan-cantu-icf

@jonathan-cantu-icf jonathan-cantu-icf commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BFD-4248

What Does This PR Do?

Enables and implements Slack Webhooks for BFD GitHub build and deploy workflow.

What Should Reviewers Watch For?

Watch the GitHub Actions for this PR during quality checks.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
The validation will be in seeing what comes out of GitHub quality checks for this PR once the changes are pushed.

@jonathan-cantu-icf jonathan-cantu-icf changed the title Feature/bfd 4248 git hub build and deploy slack notification BFD-4248: git hub build and deploy slack notification Mar 24, 2026
@jonathan-cantu-icf jonathan-cantu-icf changed the title BFD-4248: git hub build and deploy slack notification BFD-4248: Send Release and Deploy BFD Workflow run status updates to Slack Mar 24, 2026
@jonathan-cantu-icf
jonathan-cantu-icf marked this pull request as draft March 24, 2026 21:39
@jonathan-cantu-icf

jonathan-cantu-icf commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Performed some rudimentary testing and discovered that there was some deprecated code in the CDAP GitHub Actions function I pulled in to obtain the Slack Webhook:

notify-startNode.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: cmsgov/cdap/actions/aws-params-env-action@main. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

So we may want to address that before fully deploying and implementing this PR.

@jonathan-cantu-icf
jonathan-cantu-icf marked this pull request as ready for review April 15, 2026 23:52
@mjburling

Copy link
Copy Markdown
Member

[..]
notify-startNode.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: cmsgov/cdap/actions/aws-params-env-action@main. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

So we may want to address that before fully deploying and implementing this PR.

@mianava worked through these details last week: CMSgov/cdap#444

Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
@mjburling
mjburling requested a review from sb-benohe April 21, 2026 11:51
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated

@malessi malessi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things!

Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
@jonathan-cantu-icf
jonathan-cantu-icf force-pushed the feature/BFD-4248_GitHub-BuildAndDeploy-Slack-Notification branch 2 times, most recently from f4fa727 to 6694f78 Compare April 27, 2026 19:26
@jonathan-cantu-icf
jonathan-cantu-icf force-pushed the feature/BFD-4248_GitHub-BuildAndDeploy-Slack-Notification branch from 057410b to 281ab50 Compare April 27, 2026 20:55
@jonathan-cantu-icf
jonathan-cantu-icf force-pushed the feature/BFD-4248_GitHub-BuildAndDeploy-Slack-Notification branch from 281ab50 to 5aaf5e2 Compare April 27, 2026 21:09
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
Comment thread .github/workflows/release-and-deploy-bfd.yml Outdated
…ion only seems to accept it as an environment variable.
@malessi
malessi self-requested a review April 29, 2026 17:06
Comment thread .github/workflows/release-and-deploy-bfd.yml
@jonathan-cantu-icf
jonathan-cantu-icf dismissed sb-benohe’s stale review April 29, 2026 22:06

The issue was addressed.

@sb-benohe

Copy link
Copy Markdown
Collaborator

LGTM: thanks for masking the ARNs + the Pinning of the actions!

@mjburling
mjburling self-requested a review April 30, 2026 13:51
@jonathan-cantu-icf
jonathan-cantu-icf added this pull request to the merge queue Apr 30, 2026
Merged via the queue into master with commit 41072cd Apr 30, 2026
7 checks passed
@jonathan-cantu-icf
jonathan-cantu-icf deleted the feature/BFD-4248_GitHub-BuildAndDeploy-Slack-Notification branch April 30, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants