BFD-4761: Replace CW log metric filters with custom Micrometer metrics - #3164
Merged
Conversation
mel1-G
marked this pull request as ready for review
June 9, 2026 18:01
mel1-G
requested review from
alex-dzeda,
aschey-forpeople,
malessi and
mjburling
as code owners
June 9, 2026 18:01
aschey-forpeople
previously approved these changes
Jun 11, 2026
|
aschey-forpeople
approved these changes
Jun 11, 2026
marshallweekley-eng
approved these changes
Jun 18, 2026
malessi
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4761
What Does This PR Do?
Some context: If we decide to move our metrics to DataDog, we won't be able to transfer/replicate our log metric filters since we can't push up logs. Hence:
application.eob.handler.samhsa_filterwasn't actually measuring the time that the SAMHSA filtering takes since I had not included the actual execution, just the stream 😔What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Applied to test and verified that the log metric filters are gone and the dashboard is able to pull in the new custom metrics