BFD-4802: Initial Log alarm creation - #3212
Merged
Merged
Conversation
malessi
requested changes
Jul 20, 2026
malessi
left a comment
malessi
left a comment
Collaborator
There was a problem hiding this comment.
I think this looks great and is already 90% of the way there, thanks a lot for taking this on! Just a few things to address and I believe we can get this out real soon.
…checker.py Co-authored-by: Mitchell Alessio <5306896+malessi@users.noreply.github.com>
…checker.py Co-authored-by: Mitchell Alessio <5306896+malessi@users.noreply.github.com>
marshallweekley-eng
marked this pull request as ready for review
July 20, 2026 22:05
marshallweekley-eng
requested review from
alex-dzeda,
aschey-forpeople,
mel1-G and
mjburling
as code owners
July 20, 2026 22:05
marshallweekley-eng
force-pushed
the
BFD-4802
branch
from
July 21, 2026 14:30
c750a0b to
67cce1e
Compare
malessi
requested changes
Jul 21, 2026
malessi
left a comment
malessi
left a comment
Collaborator
There was a problem hiding this comment.
Just a few more small things!
marshallweekley-eng
force-pushed
the
BFD-4802
branch
from
July 22, 2026 11:55
67cce1e to
336d9c4
Compare
Co-authored-by: Mitchell Alessio <5306896+malessi@users.noreply.github.com>
malessi
requested changes
Jul 23, 2026
malessi
left a comment
malessi
left a comment
Collaborator
There was a problem hiding this comment.
Just a few very small nitpicks and I feel like this'll be ready to go.
malessi
self-requested a review
July 23, 2026 20:14
malessi
approved these changes
Jul 24, 2026
malessi
left a comment
malessi
left a comment
Collaborator
There was a problem hiding this comment.
This is great! Thanks for working through the review comments so quickly 🙂
sb-benohe
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4802
What Does This PR Do?
Creates a tofu module to alert if log retention is set below 7 years.
What Should Reviewers Watch For?
Right now we do not have any paired down topic selection. We might want that as we might not care about some log groups.
If you're reviewing this PR, please check for these things in particular:
Assure all permissions are correct
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Only security note is that it does let us know if we do not have proper setup per security/regulatory standards on logs.
@sb-benohe) approval.)Validation
Module deploys to AWS