BFD-4788: Switch from filter out to pruning for part d obsolete records - #3217
Merged
Conversation
marshallweekley-eng
requested review from
alex-dzeda,
aschey-forpeople,
malessi,
mel1-G and
mjburling
as code owners
July 21, 2026 18:51
Contributor
|
I'm sold on the repeatable script here and for future changes. I didn't know that existed. This is going to reduce a lot of the clutter of scripts. Nice find :) Happy to approve once your merge conflicts are resolved. |
…_obs_date_idx.sql Co-authored-by: aschey-forpeople <162160982+aschey-forpeople@users.noreply.github.com>
mel1-G
previously approved these changes
Jul 23, 2026
# Conflicts: # apps/bfd-pipeline-idr/pipeline_stages.py # apps/bfd-pipeline-idr/pipeline_utils.py
aschey-forpeople
approved these changes
Jul 27, 2026
mel1-G
approved these changes
Jul 27, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4788
What Does This PR Do?
Switch from filter out to pruning for part d obsolete records
What Should Reviewers Watch For?
Check prune logic and new stage. It will need to reconcile with other prune work out there based on commit order.
If you're reviewing this PR, please check for these things in particular:
Take note of the repeatable script for flyway. To date we have just created a new script to update a view. This works a little differently. Flyway checks the check sum of the repeatable file and if it changes it runs the script again. It is useful for it to be easy as an engineer to see the most up to date schema of a given view. They are typically helpful for concepts like views and functions and lets source control give revision history. They run last always in the flyway deployment. If we do not like the repeatable script its contents can be moved to an versioned script.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
N/A
@sb-benohe) approval.)Validation
Tests are updated to check for this scenario. I tested the view update and it prevents the server-ng from ever seeing the unpruned records.