Skip to content

BFD-4810: Implement Prior Auth Sync Strategy - #3227

Draft
mel1-G wants to merge 14 commits into
masterfrom
BFD-4810
Draft

BFD-4810: Implement Prior Auth Sync Strategy#3227
mel1-G wants to merge 14 commits into
masterfrom
BFD-4810

Conversation

@mel1-G

@mel1-G mel1-G commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BFD-4810

What Does This PR Do?

  • Added support for a full sync and diff load strategy for prior auth and any other future tables that don't have reliable update timestamps so we can track changes and upstream deletions
  • Added a flag on the models to opt in to this strategy without changing how any other table is loaded
  • I tried to reuse as much of the exisiting code as possible so I reused our extraction logic and detection of any updates + used some inheritance to build the new loading logic on top of the existing loader
  • Removed the IDR timestamps from the prior auth models since it's confirmed that IDR won't be providing those fields :(
  • Added a safeguard so the deletion logic doesn't run on our synthetic data in prod

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

Added prior auth update and delete tests to our pipeline tests

@mel1-G
mel1-G marked this pull request as ready for review July 27, 2026 23:13
Comment thread apps/bfd-pipeline-idr/model/base_model.py Outdated
Comment thread apps/bfd-pipeline-idr/extractor.py Outdated
Comment thread apps/bfd-pipeline-idr/src/idr_pipeline/loader.py
Comment thread apps/bfd-pipeline-idr/loader.py Outdated
Comment thread apps/bfd-pipeline-idr/src/idr_pipeline/loader.py
Comment thread apps/bfd-pipeline-idr/loader.py Outdated
Base automatically changed from BFD-4764 to master July 29, 2026 18:08
Comment thread apps/bfd-pipeline-idr/test_pipeline.py Outdated
Comment thread apps/bfd-pipeline-idr/loader.py Outdated
@mel1-G
mel1-G marked this pull request as draft August 6, 2026 16:48
@bfd-sast

bfd-sast Bot commented Aug 14, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'bfd-parent'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants