BFD-4576: Make IDR->BFD validation script run automatically on a schedule - #3229
Merged
Conversation
malessi
force-pushed
the
alessio/BFD-4576__autorun-idr-validator
branch
from
July 29, 2026 21:25
680045e to
c00eb6e
Compare
malessi
marked this pull request as ready for review
July 29, 2026 21:25
malessi
requested review from
alex-dzeda,
aschey-forpeople,
mel1-G and
mjburling
as code owners
July 29, 2026 21:25
marshallweekley-eng
previously approved these changes
Jul 30, 2026
malessi
force-pushed
the
alessio/BFD-4576__autorun-idr-validator
branch
from
July 30, 2026 16:23
c00eb6e to
43d73af
Compare
malessi
force-pushed
the
alessio/BFD-4576__autorun-idr-validator
branch
from
August 4, 2026 15:25
2fda77b to
a164bb8
Compare
mel1-G
reviewed
Aug 5, 2026
aschey-forpeople
approved these changes
Aug 5, 2026
malessi
enabled auto-merge
August 5, 2026 19:16
marshallweekley-eng
approved these changes
Aug 5, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4576
What Does This PR Do?
This PR refactors the original
idr_bfd_comparer.pyscript into its own Python utility:idr-bfd-validator. To support this, the IDR Pipeline application (bfd-pipeline-idr/idr-pipeline) has been refactored into a packaged application project such that it can be imported as a package by other Python code; in this case,idr-bfd-validator. Additionally, a new container Image (namedbfd-platform-idr-validator) is now built from theidr-bfd-validatorand a new Tofuservice,04-idr-bfd-validator, has been introduced to automatically run said container as an ECS Task automatically every hour.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependenciesModifies any security controlsAdds new transmission or storage of dataAny other changes that could possibly affect security?I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
idr-bfd-validatorlocally, verifying that it works as expectedidr-pipelinelocally, verifying that it still works as expectedidr-pipelinetests, verifying that they still passtf applyingidr-bfd-validatorinprod, verifying that itapplys successfully and the Task runs as expected and works