Conversation
JFisk42
marked this pull request as ready for review
July 29, 2026 20:50
JFisk42
requested review from
alex-dzeda,
aschey-forpeople,
malessi,
mel1-G and
mjburling
as code owners
July 29, 2026 20:50
JFisk42
changed the title
aschey-forpeople
approved these changes
Jul 29, 2026
|
mel1-G
approved these changes
Jul 29, 2026
| WHERE clm.clm_uniq_id = item.clm_uniq_id | ||
| AND item.bfd_updated_ts >= %s | ||
| ) | ||
| ORDER BY clm.clm_uniq_id |
Contributor
There was a problem hiding this comment.
Does this still cause performance issues? We observed this a few weeks ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-4831
What Does This PR Do?
Adds an ORDER BY clause to the query to ensure that it is deterministic.
What Should Reviewers Watch For?
Ensure the SQL query is still functionally valid.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Pipeline tests still pass