Skip to content

BFD-4847: Replace global node package installations with local package.json - #3254

Merged
aschey-forpeople merged 4 commits into
masterfrom
BFD-4847
Aug 12, 2026
Merged

BFD-4847: Replace global node package installations with local package.json#3254
aschey-forpeople merged 4 commits into
masterfrom
BFD-4847

Conversation

@aschey-forpeople

@aschey-forpeople aschey-forpeople commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

JIRA Ticket:
BFD-4847

What Does This PR Do?

  • Replaces global node module installation with a local package.json
    • This makes node dependencies explicit instead of implicit, removing the need for a separate install script
    • Some people were having issues with global path resolution with nvm, this should resolve that
  • Replaces the sushi build command with npm run sushi-build, in order to use the local binary instead of a global one
  • Fixes matchbox port to not conflict with the server

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

Ran locally, verified scripts still work

Comment thread apps/bfd-model-idr/out/ExplanationOfBenefit-Carrier.json
@bfd-sast

bfd-sast Bot commented Aug 12, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed for 'bfd-parent'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@aschey-forpeople
aschey-forpeople added this pull request to the merge queue Aug 12, 2026
@aschey-forpeople
aschey-forpeople removed this pull request from the merge queue due to a manual request Aug 12, 2026
@aschey-forpeople
aschey-forpeople added this pull request to the merge queue Aug 12, 2026
Merged via the queue into master with commit fabe67e Aug 12, 2026
12 checks passed
@aschey-forpeople
aschey-forpeople deleted the BFD-4847 branch August 12, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants