Skip to content

Conversation

@bwang-icf
Copy link
Contributor

JIRA Ticket:
BB2-4265

What Does This PR Do?

Enforces a standard response from match_fhir_id so that the returned results will always be in the same structure. Adds a MatchFhirIdResult class, as well as a LookupType and ErrorType.

What Should Reviewers Watch For?

Any areas where match_fhir_id has downstream results that are unexpected. Particularly as a result of _get_and_update_user.

Validation

Verified with local unit tests

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants