-
Notifications
You must be signed in to change notification settings - Fork 28
BB-4256: Remove references to old fhir_id crosswalk column #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jimmyfagan
wants to merge
25
commits into
master
Choose a base branch
from
jimmyfagan/bb2-4256-remove-old-fhir-id-refs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+0
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er waffle_flag. Working for read/search v3 calls, v3 auth/token flows (still need to add to some other auth views)
… flag is not enabled for that app
…s in the flag. Add 403 handling for userinfo v3
…Token and Authorization views
…ier in auth process
…emove validate_v3_call variable from AuthorizationView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4256
What Does This PR Do?
This PR removes references to the fhir_id column in the crosswalk table in the code so that the column can safely and seamlessly be removed by a future migration. I also removed the copy fhir_id to fhir_id_v2 command, since there's no longer a need for that.
Note: I must have accidentally started this branch off of a non-main branch, so the commit history is a little sloppy, but with the initial merge commit, it's back in sync with the main branch, and that history will get squashed back down later.
What Should Reviewers Watch For?
Are there any new unit tests needed? I don't think so, but a second opinion wouldn't hurt.
Validation
I tested this by running a variety of new v2 auth, new v3 auth, and repeat auth on each version as well. I did these without touching the database, and confirmed things works as expected, and without new data going into the fhir_id column. I then dropped the column and did all of the same combinations of auths, and still saw things working as expected. (Note that the removal of the column will not actually happen as part of this PR).
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)