Skip to content

Conversation

@jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Dec 12, 2025

JIRA Ticket:
BB2-4256

What Does This PR Do?

This PR removes references to the fhir_id column in the crosswalk table in the code so that the column can safely and seamlessly be removed by a future migration. I also removed the copy fhir_id to fhir_id_v2 command, since there's no longer a need for that.

Note: I must have accidentally started this branch off of a non-main branch, so the commit history is a little sloppy, but with the initial merge commit, it's back in sync with the main branch, and that history will get squashed back down later.

What Should Reviewers Watch For?

Are there any new unit tests needed? I don't think so, but a second opinion wouldn't hurt.

Validation

I tested this by running a variety of new v2 auth, new v3 auth, and repeat auth on each version as well. I did these without touching the database, and confirmed things works as expected, and without new data going into the fhir_id column. I then dropped the column and did all of the same combinations of auths, and still saw things working as expected. (Note that the removal of the column will not actually happen as part of this PR).

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

JamesDemeryNava and others added 25 commits November 21, 2025 09:18
…er waffle_flag. Working for read/search v3 calls, v3 auth/token flows (still need to add to some other auth views)
…s in the flag. Add 403 handling for userinfo v3
…emove validate_v3_call variable from AuthorizationView
@jimmyfagan jimmyfagan marked this pull request as ready for review December 12, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants