[DPC-5384] Me/dpc 5384 dw upgrade#3004
Conversation
|
Looks good to me! Rails dependencies seem to be causing issues with the pipelines still, but all java workflows are passing ✅ |
| @MethodSource("downloadArgs") | ||
| void canDownloadFiles(boolean compressFile, Map<String, String> requestHeaders) throws IOException { | ||
| String testData = "test data".repeat(500); | ||
| String testData = "test data".repeat(50); |
There was a problem hiding this comment.
I reduced this because the test is still occasionally failing due to resource limitations.
| enabled: true | ||
| schemaValidation: false | ||
| schematronValidation: false | ||
| schematronValidation: false # Schematron has been deprecated, we should remove this in the future. |
There was a problem hiding this comment.
do we have a ticket for this?
| @MethodSource("downloadArgs") | ||
| void canDownloadFiles(boolean compressFile, Map<String, String> requestHeaders) throws IOException { | ||
| String testData = "test data".repeat(500); | ||
| String testData = "test data".repeat(50); |
There was a problem hiding this comment.
Hey @MEspositoE14s, instead of using .repeat(50) here, why not just pass an example thats closer to what the data would look like?
There was a problem hiding this comment.
We could have, and I don't feel particularly strongly about it either way so I'm open to switching it, but from the point of view of the DataResource endpoint it doesn't care what's in the file. It doesn't even attempt to read it, just compress and uncompress it. I just wanted some junk data and this was an easy way to get it with one line of code.
| bind(ValidatorFactory.class).toProvider(ValidatorFactoryProvider.class); | ||
| bind(ConfiguredValidator.class).to(InjectingConfiguredValidator.class); | ||
|
|
||
| bind(DPCProfileSupport.class).in(Scopes.SINGLETON); | ||
| bind(FhirValidator.class).toProvider(FHIRValidatorProvider.class); |
There was a problem hiding this comment.
How come we no longer need ValidatorFactory.class and FhirValidator.class?
There was a problem hiding this comment.
These were replaced with the @Provides methods later in the same class.
- ValidatorFactory provideValidatorFactory(...)
- FhirValidator provideFhirValidator(...)
Doing it this way lets us configure the instances that get bound to ValidatorFactory and FhirValidator.
4 participants
🎫 Ticket
https://jira.cms.gov/browse/DPC-5384
🛠 Changes
Bumped DropWizard from 4.x to 5.0.1 and updated code where necessary.
ℹ️ Context
🧪 Validation
CI passes and services can start and run.