DPC-5454 - Switching login.gov from IAL1 to IAL2#3019
Open
Jose-verdance wants to merge 4 commits into
Open
Conversation
MEspositoE14s
previously approved these changes
May 29, 2026
| end | ||
|
|
||
| it 'does not set authentication token' do | ||
| it 'sets authentication token' do |
Contributor
There was a problem hiding this comment.
Unrelated to these changes, but when someone logs in through Login.gov and they don't have a user account, do we need to bother saving their token?
Contributor
Author
There was a problem hiding this comment.
Thats a good question! At first I thought it might be needed for logout but looking at the documentation, it looks like its not needed. This might be worth discussing with the team. https://developers.login.gov/oidc/logout/
Contributor
ashley-weaver
left a comment
ashley-weaver
left a comment
There was a problem hiding this comment.
Just one comment, otherwise looks good
| end | ||
|
|
||
| def path(user, auth) | ||
| if user.blank? && auth.extra.raw_info.ial == 'http://idmanagement.gov/ns/assurance/ial/1' |
Contributor
There was a problem hiding this comment.
I don't think this line should be changed, it's ensuring that the IAL level is not 1
Contributor
Author
There was a problem hiding this comment.
Updated it based on our conversation.
…is avaible before redirect to no account
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-5454
🛠 Changes
This change updates login.gov sign-in from IAL1 to IAL2.
ℹ️ Context
This is part of our larger efforts to enable and align our integration with multiple CSPs.
🧪 Validation
Local CI test pass
Successfully deployed to test and confirmed users can register and login.
https://github.com/CMSgov/dpc-app/actions/runs/26583600135