add check for test_matrix_a in gbmv,tbmv,hbmv and sbmv #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BadgerKing7
approved these changes
Aug 29, 2024
CNugteren
requested changes
Aug 29, 2024
Owner
CNugteren
left a comment
CNugteren
left a comment
There was a problem hiding this comment.
Unless I misunderstood the original issue, I don't think what you implemented here is correct. By changing clblast.h you are giving the option to the user to control whether or not the matrix A should be tested, but I thought the original issue was not about a new feature but about correctness: this matrix should be tested or it shouldn't, that is not up to the user.
Please correct me if I'm wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #538.