OpenCL resource safety #643
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cedric Nugteren <[email protected]>
This reverts commit 39bf80f.
CNugteren
reviewed
Nov 3, 2025
Owner
CNugteren
left a comment
CNugteren
left a comment
There was a problem hiding this comment.
I see two issues with this PR:
- You are using OpenCL code outside of
clpp11.hppwhich will break the CUDA back-end. - This retain and releasing can be done much cleaner and better inside the
Queueclass itself, that way you can never forget to release it, because the destructor will do that for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #641 . Adds call to
clRetainCommandQueueandclReleaseCommandQueueso that the user cannot accidentally release command queue while it is being used.