MBA-1428: Transaction submission wizard and status view - #263
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Web replacement for keying a TRANFILE record for
PORTTRAN: a two-step submission wizard (details → review & confirm) plus a transaction status view, backed by a mock service over aTRNREC.cpy-shaped fixture. Stacked on the MBA-1427 position branch; the transactions nav item is now enabled.Validation mirrors the COBOL paragraphs rather than inventing new rules:
PORT+ 4 digitsPORTVALD1000-VALIDATE-IDPORTTRAN2110-CHECK-PORTFOLIOPORTTRAN2120-CHECK-TRANSACTION-TYPETRPORTTRAN2130-CHECK-AMOUNTSPORTTRAN2220-PROCESS-SELLDigit limits come straight from the copybook (
S9(11)V9(4)quantity/price,S9(13)V9(2)amount), so an overflowing amount is rejected before review.Two BigInt decimal helpers keep COMP-3 precision — no
Numberanywhere in the money path:The sell-balance check runs before the review step (and again in the service on submit), and treats already-pending sells as encumbered:
Submitted records are written with
TRN-STATUS = 'P', stamped date/time/sequence, and settle on the nextPORTTRANrun — the list view surfaces P/D/F/R with filters on portfolio, status and type.Reusable
FormFieldwas lifted out ofPortfolioFormPage(no behaviour change) so both forms share it.Jira: https://cog-gtm.atlassian.net/browse/MBA-1428
Screenshots
Submission form with auto-calculated amount:
Review & confirm step:
Status view after submit:
Testing
npm run lint,npm run typecheck,npm run build,npm test(71 tests) all pass. New coverage: amount truncation, validation rules, mock service (unknown portfolio, oversell, pending-sell encumbrance), and a full wizard flow test.Link to Devin session: https://app.devin.ai/sessions/9b436d246db74e7f91301fb25f38af54
Devin Review