MBA-1433: Add frontend web UI for portfolio management (mocked data) - #270
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a frontend-only web UI under
frontend/(React 18 + TypeScript + Vite, react-router-dom) modernizing the CICS/BMS screens — all data is mocked; no COBOL sources touched. Jira: MBA-1433Key design points:
src/api/: typedApiClientinterface + in-memoryMockApiClient(simulated latency), so a real backend can replace the mock without UI changes.types.tsmirrors the copybooks (PORTFLIO,POSREC,TRNREC,HISTREC) — e.g.Transaction.type: 'BU'|'SL'|'TR'|'FE',Portfolio.status: 'A'|'C'|'S'.src/validation/portvald.tsports the PORTVALD.cbl rules exactly (PORTnnnn id, 10-digit non-zero account, type ∈ {STK,BND,MMF,ETF}, ±9999999999999.99 amount) with matching PORTVAL.cpy error messages; covered by Vitest unit tests.Run:
cd frontend && npm install && npm run dev(seefrontend/README.md). Lint,npm run build, andvitest runall pass.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/8725bad5e57d4f519746e4e3f714f0d5
Open in Devin Desktop: https://app.devin.ai/desktop/session/8725bad5e57d4f519746e4e3f714f0d5?variant=devin
Devin Review