Add AWS migration architecture package (docs only) - #292
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…t-state, open-questions, migration-plan) Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only. Adds
docs/architecture/with four documents derived by reading the source, build files,K8s/Helm manifests, Jenkinsfiles, shared library, Compose, and setup READMEs at
305826d. Noapplication code changed — the diff is four new markdown files. All four Mermaid diagrams were
rendered with
mermaid-clito confirm they parse.current-state.md— as-coded architecture withfile:lineevidence on every claim; inferenceslabelled
[INFERENCE].target-state.md— AWS target under multi-AZ dev / multi-region prod, Postgres, ECS Fargate,Harness CD; 24-row mapping table with rationale / risk / effort.
open-questions.md— 40 questions addressed to named roles (DBA, Platform, Release, Security,App Owner), graded B1/B2/B3 by what they block.
migration-plan.md— 14 workstreams (WS0–WS13) with an explicit dependency graph and cutoverentry criteria.
Blocked input
The request specified
[PASTE BLESSED SERVICE LIST]as a literal placeholder. Nothing was silentlysubstituted:
target-state.md§0 states the assumed list, and every service that is off it orcommonly excluded is tagged
OFF-LIST?with an in-list fallback (Terraform → CloudFormation/CDK;Managed Grafana/Prometheus → CloudWatch; ElastiCache → ALB stickiness). One diff pass against the
real list closes it.
Findings that changed the plan (all read from files, not assumed)
These are facts, not risks, and they are why the sequencing is gated rather than a straight lift:
LondheShubham153/Springboot-BankApp(Jenkinsfile:26,GitOps/Jenkinsfile:21) and CD pushescommits back to it. Four different image references exist for one app (CI publishes
madhupdevops/bankapp; the Deployment pullstrainwithshubham/bankapp-eks:v2).sededitskubernetes/bankapp-deployment.yaml,but the file is
bankapp-deployment.yml(GitOps/Jenkinsfile:40).ddl-auto=update(application.properties:9), noFlyway/Liquibase, and the only SQL in the repo is
CREATE DATABASE. The Postgres port thereforedepends on extracting the schema from a live DB (WS5 gates WS6).
JdbcTemplate— access is 2 entities and 2 derived finders. Risk sits in schema conversion, not application SQL.
/actuator/healthdoes not exist — no actuator dependency inpom.xml, yet it is the healthcheck in
docker-compose.yml:36and both Helm probes. ALB target groups need it.needs rotating.
non-atomic
transferAmountwith no@Transactional, CSRF disabled on money-moving POSTs, and asingle hardcoded
"USER"authority.Critical path ≈ 11 Devin sessions (WS0 → WS5 → WS6 → WS7 → WS8 → WS11 → WS12 → WS13); ~17 total.
Elapsed time is dominated by the WS0 answers, credential-rotation approval, and the DR/cutover
windows — all of which should start in parallel with WS1.
Link to Devin session: https://app.devin.ai/sessions/32cf1817309847cc9500aec9e4008005
Requested by: @patrickbradley-cog
Devin Review