Upgrade NuGet packages to clear all Snyk high-severity findings - #68
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: shayan <shayan@cognition.ai>
Co-Authored-By: shayan <shayan@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch-level dependency upgrades that clear all 5 HIGH Snyk findings without leaving .NET 7 and without touching application code. Four of the five vulnerable packages are transitive, so they are fixed by bumping the direct parents (EF Core 7.0.10 -> 7.0.20 pulls
Microsoft.Data.SqlClient5.0.2 -> 5.1.5, which drops the vulnerableSystem.Drawing.Common5.0.0). Two packages are pinned explicitly because the version the graph resolves to is itself vulnerable and its 7.0.x parent line was never patched:System.Text.Json8.0.6 — transitive 7.0.0 came viaMicrosoft.Extensions.DependencyModel7.0.0; the package supports net7.0, so no TFM change.Azure.Identity1.13.2 —Microsoft.Data.SqlClient5.1.5 pulls 1.10.3, which fixes the high RCE but introduces two new mediums (SNYK-DOTNET-AZUREIDENTITY-6597976, -7246762) and drags in a vulnerableMicrosoft.Identity.Client4.56.0. Pinning 1.13.2 means this PR introduces zero new findings at any severity.Version changes:
Microsoft.EntityFrameworkCore,.Design,.SqlServer,.Tools: 7.0.10 -> 7.0.20Npgsql: 7.0.4 -> 7.0.10 (fix line is 7.0.7+)Npgsql.EntityFrameworkCore.PostgreSQL+.NodaTime: 7.0.4 -> 7.0.18 (kept in step with Npgsql)Microsoft.AspNetCore.OpenApi: 7.0.9 -> 7.0.20System.Text.Json8.0.6,Azure.Identity1.13.2.github/workflows/dotnet.yml):dotnet-version6.0.x -> 7.0.x. The workflow installed the 6.0 SDK while the projects target net7.0, sodotnet testaborted on the runner with "You must install or update .NET to run this application" — that failure predates this PR and blocked any green build.All package upgrades stay within their existing major version.
dotnet buildis clean (same 3 pre-existing nullable warnings) and all 20 tests pass.Snyk findings fixed
Before / after (
snyk test --all-projects --detection-depth=4, Snyk CLI 1.1306.4):0 critical before and after; high 28 (with cross-project duplicates) -> 0. The one remaining medium is a test-only transitive in
Microsoft.NET.Test.Sdk.Intentionally not fixed here
mcr.microsoft.com/dotnet/aspnet:7.0, out of support and heavily vulnerable per Snyk (184 vulns / 6 critical). That needs a framework bump, done separately in Upgrade to .NET 8 LTS (out-of-support runtime and base image) #69 (net8.0 +aspnet:8.0). Upgrade to .NET 8 LTS (out-of-support runtime and base image) #69 supersedes this PR; this one exists as the low-risk option if you would rather not move framework versions yet.Microsoft.EntityFrameworkCore.SqlServeris referenced but unused (noUseSqlServer/SqlClientanywhere in.cs). Removing it would delete the whole SqlClient/Azure.Identity/Drawing chain, but that is a dependency-surface change, so it was upgraded rather than dropped.Link to Devin session: https://app.devin.ai/sessions/515d976343dd48cd8c94e0ffe96bc259
Requested by: @shayanshafii
Devin Review