Upgrade to .NET 8 and remediate high-severity dependency vulnerabilities - #70
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates the 5 high-severity open-source findings from the Snyk audit. All of them (System.Text.Json 7.0.0, Azure.Identity 1.6.0, Microsoft.Data.SqlClient 5.0.2, System.Drawing.Common 5.0.0, Npgsql 7.0.4) were transitive, so the fix is a framework/provider bump plus removing one unused provider — not five direct pins.
Changes:
net7.0->net8.0in all 6 projects; Dockerfileaspnet:7.0/sdk:7.0->8.0(also moves the runtime image off the Debian 11 base with the openssl/perl-base/pam/systemd OS vulns).Microsoft.AspNetCore.OpenApi7.0.x ->8.0.11, Npgsql8.0.8, Npgsql EF provider (+NodaTime)8.0.11,AspNetCore.HealthChecks.NpgSql8.0.2. EF pinned to 8.0.11 rather than the newest 8.0.x patch to match the assembly version the Npgsql provider references (mixing 8.0.29 produced MSB3277EntityFrameworkCore.Relationalconflicts).Microsoft.EntityFrameworkCore.SqlServer— no code references SqlServer (Postgres-only app), and it was the sole path toMicrosoft.Data.SqlClient->Azure.IdentityandSystem.Drawing.Common. This removes those three findings entirely instead of pinning patched versions of packages we don't use.System.Text.Json 8.0.5reference in Infrastructure so the transitive7.0.0can't float back in.setup-dotnetwas pinned to6.0.x(it only built because the runner had newer SDKs preinstalled) ->8.0.x.Verification:
dotnet buildclean (no NU1903/NETSDK1138),dotnet test20/20 passing,snyk test --all-projects --severity-threshold=high-> 6 projects, no vulnerable paths.Note: .NET 8 is the current LTS the audit asked for, but its support ends Nov 2026 — a follow-up move to .NET 10 LTS is worth scheduling.
Link to Devin session: https://app.devin.ai/sessions/91f2594952524217ba24fb964b49f67b
Requested by: @shayanshafii
Devin Review