Phase 3: integrate React features, Playwright e2e, docs; remove Angular - #718
Open
vibhaseshadri-cognition wants to merge 12 commits into
Open
vibhaseshadri-cognition wants to merge 12 commits into
vibhaseshadri-cognition wants to merge 12 commits into
Conversation
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
…ils' into devin/1788306894-react-integration
…o devin/1788306894-react-integration
…ut' into devin/1788306894-react-integration
…e2e job Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final migration phase. Merges the four Phase 2 feature branches (#714 #715 #716 #717) and wires them into the shell, replaces Protractor with API-mocked Playwright e2e, points hosting/CI/docs at
react/, then removes the Angular source and dependencies.Route wiring (
react/src/App.tsx), mirroring Angular's lazyitem/usermodules:react/src/app/placeholders.tsx(Phase 2 route contract) is deleted.Playwright e2e (
react/e2e/) intercept**/node-hnapi.herokuapp.com/**viainstallApiMocks(page)+ fixtures so runs are deterministic:feeds(all 5 types + jobs header),pagination(More only at 30 items, Prev/<ol start=31>on page 2),item(open item, collapse/expand[-]/[+], deleted comment, mobile back button),user,settings(3 themes → wrapper class + localStorage, open-in-new-tab →target=_blank, font size / list spacing CSS, close). CI workflow now runs on every push/PR (noreact/**path filter) and gained ane2ejob.Hosting/CI/docs:
firebase.json→public: react/dist;.travis.yml→ Node 20,cd react && npm ci && npm run build; README/CONTRIBUTING rewritten for the Vite/Vitest/Playwright commands.Angular removal (last two commits):
src/,e2e/(Protractor),angular.json,karma.conf.js,tslint.json,tsconfig*.json,browserslist,ngsw-config.json,yarn.lock; rootpackage.jsonkeeps only delegating scripts (npm --prefix react run …) and no dependencies.Angular → React mapping (cumulative)
src/app/app.component.*,app.module.tsreact/src/App.tsx,react/src/core/Layout.tsx,useGoogleAnalytics.tssrc/app/app.routes.tsreact/src/app/routes.tsxsrc/app/core/{header,footer,settings}react/src/core/{Header,Footer,Settings}.tsxsrc/app/feeds/{feed,item}react/src/features/feed/{Feed,StoryItem}.tsxsrc/app/item-details/**react/src/features/item/{ItemDetails,Comment}.tsxsrc/app/userreact/src/features/user/User.tsx(UserProfile)src/app/shared/components/{loader,error-message}react/src/shared/components/{Loader,ErrorMessage}.tsxsrc/app/shared/services/*,pipes/comment.pipe.ts,models/*react/src/shared/{services,utils,settings,models}src/app/shared/scss/*,src/styles.scssreact/src/styles/*e2e/(Protractor)react/e2e/*.spec.ts(Playwright)ngsw-config.json/src/manifest.jsonvite-plugin-pwainreact/vite.config.tsTests
react/: lint, format:check, build, Vitest 19 files / 105 tests, Playwright 11 tests — all passing locally (Node 20). Rootnpm run builddelegates correctly.Rendered against the live API (
/news/1, then Night theme via the settings cog):Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/4b8f787ce33648ab865a05a3aa4d6cad
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b8f787ce33648ab865a05a3aa4d6cad?variant=devin
Requested by: @vibhaseshadri-cognition