Skip to content

[3/7] React migration: Header, Footer and Settings panel - #746

Open
devanshi-gpta wants to merge 1 commit into
devin/1788560000-react-02-sharedfrom
devin/1788560000-react-03-chrome
Open

devanshi-gpta wants to merge 1 commit into
devin/1788560000-react-02-sharedfrom
devin/1788560000-react-03-chrome

Conversation

@devanshi-gpta

Copy link
Copy Markdown

Summary

Ports the app chrome from src/app/core/ and mounts it in App. Header renders the settings panel itself when settings.showSettings is true, exactly as the Angular template did with *ngIf.

  • routerLink + routerLinkActiveNavLink with an isActive class callback; the scroll-to-top click handler is preserved.
  • Settings translates the theme radios, font-size and spacing selects and the new-tab checkbox into controlled inputs driven by useSettings().
  • Header image src values are root-relative (/assets/images/logo.svg). Angular resolved the relative form via <base href="/">, which Vite's index.html has no equivalent for — left relative, the logo and cog 404 on any nested route such as /item/123.
  • Stylesheets are wrapped in .c-header / .c-footer / .c-settings to replace Angular's emulated encapsulation.

Proposed fixes

  • Add Header.tsx, Footer.tsx, Settings.tsx and their stylesheets.
  • Render Header and Footer in the App layout.

Link to Devin session: https://app.devin.ai/sessions/a3a0ff57bab64e25860349a003a282ef
Open in Devin Desktop: https://app.devin.ai/desktop/session/a3a0ff57bab64e25860349a003a282ef?variant=devin
Requested by: @devanshi-gpta

Co-Authored-By: Devanshi Gupta <devanshi.gupta@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant