PR 2/10 — Port shared models and SCSS - #754
Open
devanshi-gpta wants to merge 1 commit into
Open
devanshi-gpta wants to merge 1 commit into
devanshi-gpta wants to merge 1 commit into
Conversation
Co-Authored-By: Devanshi Gupta <devanshi.gupta@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Angular -> React migration chain; based on
devin-09.08.2026-devanshi/scaffold-react-vite-app. Types-and-styles only — no components or logic.src/app/shared/models/*.ts->react-app/src/models/, converted from classes tointerfaces (they were used purely as types);FeedTypestays a string-literal union. Field names/types unchanged, exceptStorygains the optionalcontentandtextfields the Angular templates read (item.content/item.text), and fields the HN API omits are optional (Story.url|domain|comments|poll|poll_votes_count|deleted|dead,Comment.deleted,User.about).Story.time_ago: numberis kept verbatim from the Angular model even though the API returns a string, to avoid behavioural drift in this PR._media.scss,_theme_variables.scss,_themes.scsscopied unchanged intoreact-app/src/styles/(their relative@imports still resolve).src/styles.scss->react-app/src/styles/styles.scsswith the import repointed to./themesand the Angular-only host selectors swapped for the React root:main.tsximports./styles/styles.scssglobally (not CSS Modules, so theme class names stay global).Proposed fixes
vite.config.ts:test.passWithNoTests: true— the scaffold has a vitest setup but no spec files yet, sonpm testexited 1 on the base branch; later PRs in the chain add real tests.@import/darken()from the copied theme files; left as-is to keep the copy faithful, worth a follow-up to move to@use/color.adjust.Verified in
react-app/:npm run typecheck,npm run lint,npm test,npm run buildall pass.Link to Devin session: https://app.devin.ai/sessions/09c4d1e3aa4f4f928ab6f6b0ac47ee03
Open in Devin Desktop: https://app.devin.ai/desktop/session/09c4d1e3aa4f4f928ab6f6b0ac47ee03?variant=devin
Requested by: @devanshi-gpta