PR 4/10 — Port settings service to a React context - #756
Open
devanshi-gpta wants to merge 1 commit into
Open
devanshi-gpta wants to merge 1 commit into
devanshi-gpta wants to merge 1 commit into
Conversation
Co-Authored-By: Devanshi Gupta <devanshi.gupta@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the Angular → React migration chain; based on
devin-09.08.2026-devanshi/port-hackernews-data-layer.Ports
src/app/shared/services/settings.service.tstoreact-app/src/context/SettingsContext.tsx(SettingsProvider+useSettings(), which throws outside the provider). Same localStorage keys/defaults and the same persistence behaviour per setter;showSettingsstays in memory only.The one non-mechanical part is
initTheme: Angular re-dispatched a syntheticMediaQueryListEventto reuse its change handler. Here the effect calls the same handler directly with theMediaQueryListwhen no theme is saved, so the mount path and thechangepath share one code path without faking an event:Note the saved
themeis read in the initial state (Angular hardcoded'default'then overwrote it ininitTheme), so no first-render flash of the wrong theme.Proposed fixes
react-app/src/context/SettingsContext.tsx: provider withtoggleSettings,toggleOpenLinksInNewTab,setTheme,setFont,setSpacing; memoised context value.react-app/src/context/SettingsContext.test.tsx: vitest coverage for defaults, localStorage reads/writes,showSettingsnot persisted, saved theme winning over the system preference, liveprefers-color-schemechanges, and listener cleanup on unmount (window.matchMediais stubbed — jsdom has no implementation).npm run typecheck,npm run build,npm run lintandnpm testpass inreact-app/.Link to Devin session: https://app.devin.ai/sessions/451b5e68d2dc4745ba01847041b9c0af
Open in Devin Desktop: https://app.devin.ai/desktop/session/451b5e68d2dc4745ba01847041b9c0af?variant=devin
Requested by: @devanshi-gpta