refactor(mcp): migrate mcp_service/index.js to TypeScript - #23
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrates the Node.js entry point
superset/mcp_service/index.jsto TypeScript, per the ongoing "NO JavaScript files" frontend modernization.index.jswithindex.ts: theSupersetMCPServerclass is now fully typed. Constructor options are captured in aSupersetMCPServer.Optionsinterface (with aTransport = 'http' | 'stdio'union), and the internal subprocess handle is typed asChildProcess | null(viachild_process). Unusedrequires (spawn,path) from the original file were dropped.export = SupersetMCPServer, sotscemitsmodule.exports = SupersetMCPServer—require('@superset/mcp-server')still returns the class directly, unchanged from before.tsconfig.json(strict, CommonJS target,declaration: true,outDir: dist) that compiles onlyindex.ts.package.json:main→dist/index.js, addstypes→dist/index.d.tsbuild(tsc -p tsconfig.json) andprepublishOnlyscriptsfiles: [dist, bin]typescriptand@types/nodedevDependencies (+package-lock.json)dist/is already covered by the repo root.gitignore, so build artifacts are produced onnpm run build/ publish rather than committed. Thebin/superset-mcp.jsrunner is unchanged (out of scope).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/e148ac05a34d410aa25f94e955c07f48
Requested by: @shayanshafii
Devin Review