Skip to content

refactor(mcp_service): migrate index.js to TypeScript - #24

Open
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1784848690-migrate-mcp-index-ts
Open

devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
devin/1784848690-migrate-mcp-index-ts

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 23, 2026

Copy link
Copy Markdown

SUMMARY

Migrates superset/mcp_service/index.js to TypeScript (index.ts) per the repo's "NO JavaScript files" modernization guideline.

  • Adds SupersetMCPServerOptions interface and Transport type; options is Required<SupersetMCPServerOptions> and process is typed as ChildProcess | null
  • Converts CommonJS require/module.exports to ES import/export default
  • Updates package.json main from index.js to index.ts

Verified with tsc --noEmit --strict (clean) and pre-commit hooks (passed).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Type-check the file: superset-frontend/node_modules/.bin/tsc --noEmit --module commonjs --target es2020 --strict --esModuleInterop --typeRoots superset-frontend/node_modules/@types --types node superset/mcp_service/index.ts

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Link to Devin session: https://app.devin.ai/sessions/93ef63ea0dda4d639ae1bbe93ec9a778
Requested by: @shayanshafii


Devin Review

Status Commit
⚪ Not started

Run Devin Review

Open in Devin Review (Staging)

Co-Authored-By: shayan <shayan@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants