chore(deps): patch critical Snyk findings in frontend & docs deps - #25
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…t-driver, shell-quote, immutable to patch critical Snyk findings Co-Authored-By: shayan <shayan@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Runtime verification — dependency-security bump did not break the appRan the branch locally (Flask backend :8088 + frontend dev-server :9000, examples loaded) and clicked through the app in a browser, focusing on the security-relevant handlebars ^4.7.8 → ^4.7.9 bump. Resolved version confirmed Handlebars chart plugin (primary target) — works end to end:
Golden-path regression sanity (all passed)Login, Dashboards list, an open dashboard (chart tiles render), Explore (chart renders), and SQL Lab all load normally with no module-load/white-screen crash and no console errors referencing handlebars. Note on the helper screenshotThe template editor (Ace) has live autocomplete that swallowed the space separator during automated typing; the template value was set via the editor API to place the space reliably. Same runtime render path — not an app issue. Verified via Devin session. |
SUMMARY
Fixes the critical open-source Snyk findings in the npm workspaces (
superset-frontend/,docs/) from the 2026-07-27 security audit. The change is intentionally scoped to critical-severity dependency upgrades and kept minimal by usingoverrides(npm) /resolutions(yarn) plus lockfile regeneration, rather than touching each of the 20+ pluginpackage.jsonfiles.Critical CVEs addressed
handlebarsis the most important: it reaches ~20 packages includingplugins/plugin-chart-handlebars, which renders user-supplied templates. All upgrade targets were published well over 7 days ago.How the versions are pinned
superset-frontend/package.json: addedhandlebars/simple-gitto the existingoverrides. Becausehandlebarsis also a direct/peer dependency, its four direct-dependency ranges were bumped^4.7.8→^4.7.9so npm accepts the override (npm rejects an override that conflicts with a direct dependency).docs/package.json: addedaxios,node-forge,websocket-driver,shell-quotetoresolutions.immutableis pinned directly indocs/yarn.lockfor its two major lines (^3.x.x→ 3.8.3,^5.0.2→ 5.1.5) because yarn v1 selective resolutions can't cleanly target two majors of one package without breaking the other consumer.Before / after (
snyk test)--all-projects)Deliberately NOT fixed (follow-ups)
SNYK-JS-ESBUILD-17750822, docs): the consuming package declaresesbuild "... || ^0.25.0", so 0.28.x is outside its supported range and forcing it is a build-tooling migration — skipped per scoping guidance.superset/views/core.py,superset/security/api.py,superset/views/auth.py,superset/views/datasource/views.py,superset/async_events/api.py; the ReDoS insuperset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts:103,117; the vulnerable lockfiles under.github/actions/*; and the 20 medium Helm chart hardening issues.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes. Ran the branch locally (Flask backend + frontend dev-server, examples loaded) and clicked through the app to confirm the dependency bumps did not break anything. Focused on the
handlebarsupgrade sinceplugins/plugin-chart-handlebarsrenders user-supplied templates (resolved version confirmed4.7.9).Handlebars chart — custom template
{{formatNumber 1234567}}renders1,234,567(runtime compile + built-in helper):Golden-path regression sanity (all render normally, no console errors):
TESTING INSTRUCTIONS
cd superset-frontend && npm run lint→ passes (0 errors).pre-commit runon the changed files → passes.cd superset-frontend && snyk test --all-projects→ 0 criticals.cd docs && snyk test→ only the deliberately-skippedesbuildcritical remains.ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/3a47381790f44765b8d1a7aa1703a9a1
Requested by: @shayanshafii
Devin Review