chore(deps): fix critical Snyk npm vulnerabilities in superset-frontend and superset-websocket - #27
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…erset-websocket Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Clears every critical npm advisory from the 2026-08-10 Snyk audit that is reachable from
superset-frontend/andsuperset-websocket/. All affected packages are dev/build-time dependencies excepthandlebars, which is a declared runtime dependency of the frontend,@superset-ui/coreand two chart plugins.Changes are limited to manifest ranges plus lockfile resolutions — no source changes:
handlebars^4.7.8→^4.7.9insuperset-frontend/package.json,packages/superset-ui-core,plugins/plugin-chart-handlebars,plugins/legacy-preset-chart-deckgl(the plugin manifests have no lockfile of their own, so Snyk scans their declared ranges — the range bump is what clears them).superset-websocket's handlebars is transitive viats-jest@^4.7.8, so only its lockfile needed refreshing.overridesinsuperset-frontend/package.json, pinned to Snyk'sfixedInversion rather than latest, for the transitive dev deps that have no parent upgrade available:Snyk critical counts,
snyk test --all-projects --exclude=node_modules --dev --severity-threshold=criticalinsuperset-frontend/(29 sub-projects):Cleared:
SNYK-JS-AXIOS-16298058,-16299904,-16417750,SNYK-JS-ESBUILD-17750822,SNYK-JS-HANDLEBARS-15803082,-15803084,-15803086,SNYK-JS-SHELLQUOTE-16799355,SNYK-JS-SIMPLEGIT-15456078.superset-websocketgoes from 3 critical (handlebars) to 0 in scope.Deliberately not addressed here (out of the requested scope): the remaining critical advisories in
flatted@3.4.1,undici@7.24.1andwebsocket-driver@0.7.4, all 100 high / 133 medium dependency issues, Python dependencies, the Snyk Code findings, and the EOL base images in.github/actions/*/Dockerfile.immutableandnode-forgefrom the audit list do not exist in these two projects — they are only indocs/yarn.lockand are handled separately.Note on diff size: the hand-written change is 6 manifest lines; the rest is
package-lock.jsonregeneration, which is a net reduction (-616 lines) because the pinnedesbuild/axios/shell-quoteversions dedupe several nested trees.TESTING INSTRUCTIONS
In
superset-frontend/on Node 22:npm install(lockfile applies cleanly; installed versions are axios 1.15.2, esbuild 0.28.1, handlebars 4.7.9, shell-quote 1.8.4, simple-git 3.36.0)npm run lint— passes (1512 pre-existing warnings, 0 errors)npm run build— webpack production build succeedsnpx jest plugins/plugin-chart-handlebars packages/superset-ui-core/test/utils— 16 suites / 41 tests pass (handlebars is the only runtime dep changed)snyk test --all-projects --exclude=node_modules --dev --severity-threshold=criticalPre-existing failures unrelated to this change, seen on a clean tree in this environment:
npm run typereportsTS6305for everypackages/*/libandplugins/*/liboutput because packagelib/artifacts are not built (requiresnpm run build-packagesfirst), and the webpack build needs thezstdbinary installed on the host.ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/e830b59b235d402ca2915949601f2b4a
Requested by: @shayanshafii
Devin Review