chore(deps): bump vulnerable ws/lodash deps in superset-websocket and cypress-base - #31
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Lockfile-only updates clearing the high-severity ws and lodash advisories in superset-websocket and the lodash, nanoid, browserslist, picomatch and brace-expansion advisories in the Cypress test project.
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Third and last PR of the Snyk remediation series (after #29 for the Snyk Code findings and #30 for
superset-frontenddependencies). Lockfile-only updates — nopackage.jsonrange changes, no source changes — for the two remaining npm projects Snyk flags with high-severity, fixable advisories.superset-websocket:superset-frontend/cypress-base(test-only project):lodash→ 4.18.1,nanoid→ 5.1.16,browserslist→ 4.28.8,picomatch→ 2.3.2,brace-expansion→ 1.1.18.Snyk IDs fixed
wshigh (fixed in 8.21.0) andlodashhighSNYK-JS-LODASH-15869625insuperset-websocket— that project now reports 0 critical / 0 high.cypress-base:lodashSNYK-JS-LODASH-15869625,nanoid(3 highs),browserslist,picomatch, and the fivebrace-expansionhighs (SNYK-JS-BRACEEXPANSION-15789759,-16755174,-17706650,-18313044,-18512280).Before/after severity counts (
snyk test, per project)superset-websocket/package-lock.jsonsuperset-frontend/cypress-base/package-lock.jsonIntentionally left unfixed
js-yaml4.1.0 incypress-base(2 highs) — the fix is 4.3.1, but the resolved version is constrained by a transitive dependency's range; forcing it needs anoverridesentry, which changes resolution for the Cypress toolchain. Left out rather than risk the test harness.docs/yarn.lock— this is where the remaining criticals live (axios,esbuild,immutable,node-forge,shell-quote,websocket-driver,@pnpm/npm-conf). They are all deep Docusaurus transitives in the docs-site build only, and fixing them means either major-version bumps of Docusaurus packages or broadresolutionsentries. Not forced here; worth a dedicated PR with a docs-site build check.xlsx0.20.3,image-size,extract-zip— Snyk lists no fixed version (see chore(deps): bump handlebars and other critical/high vulnerable frontend deps #30).TESTING INSTRUCTIONS
Results in this environment:
superset-websocket:tscbuild succeeds;jest— 2 suites / 30 tests passed; resolvedws@8.21.3,lodash@4.18.1.cypress-baseis a test-only project and its Cypress suite is not runnable here (needs a live Superset instance); CI is the authority for it.snyk testper project confirms the counts in the table above.pre-commit runon the staged files: prettier and all other applicable hooks pass.ADDITIONAL INFORMATION
Link to Devin session: https://app.devin.ai/sessions/4ccdbedf9b264547af9397f521fc90fc
Requested by: @shayanshafii
Devin Review