Add Terraform equivalent of RDS/RDS_PIOPS.yaml - #2
Open
samanthataylor3 wants to merge 1 commit into
Open
samanthataylor3 wants to merge 1 commit into
samanthataylor3 wants to merge 1 commit into
Conversation
Create RDS/RDS_PIOPS_terraform/ with main.tf, variables.tf, and outputs.tf that mirror the CloudFormation template's resources: - random_password (16-char, excluding CFN ExcludeCharacters) - aws_secretsmanager_secret + secret_version - aws_db_instance (MySQL, 100GB, io1/1000 IOPS, encrypted, private) Passes terraform fmt and terraform validate. Co-Authored-By: Samantha Taylor <samantha.taylor@cognition.ai>
Original prompt from Samantha
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
RDS/RDS_PIOPS_terraform/— a Terraform configuration functionally equivalent toRDS/RDS_PIOPS.yaml. The original CloudFormation file is untouched.New files:
main.tfrandom_password(16-char, excludes"@/\),aws_secretsmanager_secret+_version,aws_db_instance(MySQL, 100 GB,io1/1000 IOPS, encrypted, not public,skip_final_snapshot = true)variables.tfvar.db_user— sensitive, validated to match CFNAllowedPattern(^[a-zA-Z][a-zA-Z0-9]*$, 1-16 chars)outputs.tfdb_instance_endpoint,db_instance_arn,secret_arnKey mapping notes:
storage_typefromIops; Terraform requires explicitstorage_type = "io1".skip_final_snapshotconcept; Terraform requires it — set totruewith a comment recommendingfinal_snapshot_identifierfor production.override_specialonrandom_passwordis set to a whitelist of allowed specials (excluding"@/\), matching the CFNExcludeCharacters.Passes
terraform fmtandterraform validate.Link to Devin session: https://app.devin.ai/sessions/29bda0e77a9e466db92ab7af6e81c855
Requested by: @samanthataylor3
Devin Review