docs: feature - reverse-engineering & code-forward architecture - #15
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
docs/architecture/reverse-engineering-and-code-forward.html— a self-contained (inline CSS + Mermaid 10) architecture document produced by the "Reverse-Engineering & Code-Forward Architecture" playbook against commit7998b9b, plus the five rendered figures underdocs/architecture/figures/. No application code, build file or schema is changed; this is documentation only, derived from read-only source inspection (no build/test/run executed).Sections 2–5 are observed (each row cites
file:line), 6–7 are proposed:Top findings (details and citations in the document):
account-service→customer-serviceFeign call targetsGET /bank/intern/verify/{id}, which no controller serves; every error collapses toCustomerNotFoundException, so account creation cannot succeed at this commit.account-servicealso posts notifications to/bank/mailing/sendwhilenotification-serviceserves/bank/notifications/send.customer,userand the account projection with no synchronising event; contracts are duplicated by copy (NotificationRequestDTO×3,JWTAuthorizationFilter×3).LocalDateTime.now()at the REST edge copied into events;BigDecimalwith no scale/currency on operations/transfers), transfers are two commands with a plain compensating credit, and security is per-service copy-paste (no auth at gateway,notification-servicehas no security dependency).Figures
Verification
python3 -m http.server 8090, rendered through the existing browser (CDPlocalhost:29229):document.querySelectorAll('.mermaid svg').length === 5, no "Syntax error" element.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/8504526a75614457bfa76fd470e64968
Open in Devin Desktop: https://app.devin.ai/desktop/session/8504526a75614457bfa76fd470e64968?variant=devin
Requested by: @patrickbradley-cog