Add comment unit tests and Cypress API tests - #121
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Workstream A (unit tests): - Test createComments with notification side effects for sender/receiver - Add comment object shape assertions (id, uuid, content, userId, etc.) - Test getCommentsByTransactionId returns empty array for no comments Workstream B (API tests): - Add unauthenticated request tests (401) for GET and POST - Add invalid transactionId validation test (422) for GET - Add missing content body validation test (422) for POST - Add invalid transactionId validation test (422) for POST - Enhance GET test with response body shape validation - Enhance POST test with persistence verification via follow-up GET Co-Authored-By: Scotty Andrade <scotty.andrade@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Devin Review
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive test coverage for the comments feature across two independent workstreams:
Workstream A — Unit tests (
src/__tests__/comments.test.ts):createComments(plural) with notification side effects: verifies that callingcreateCommentswith a third-party user (not sender/receiver) creates the comment and generates notifications for both the transaction's sender and receiverCommentinterface properties (id,uuid,content,userId,transactionId,createdAt,modifiedAt)getCommentsByTransactionIdreturns an empty array for a transaction with no commentsWorkstream B — Cypress API tests (
cypress/tests/api/api-comments.spec.ts):1234triggers validation errorReview & Testing Checklist for Human
npx vitest run src/__tests__/comments.test.tsnpx cypress run --spec cypress/tests/api/api-comments.spec.ts(requires app running)cy.clearCookies()runs after thebeforeEachloginNotes
createCommentstest exercises the branch atbackend/database.ts:675whereuserId !== senderId || userId !== receiverIdLink to Devin session: https://app.devin.ai/sessions/042dcfa0177c41e5bcda348450583fed
Requested by: @scottyandrade99