refactor: extract NotificationBadge from NavBar with unit tests - #125
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Extract badge logic into standalone NotificationBadge component - Accept notificationCount prop (hides badge at 0, shows count otherwise) - Add 7 unit tests covering zero/single/multiple/large counts, icon, link, and data-test attributes - Update NavBar to use the new component Co-Authored-By: Vedant Khanna <vedantkhanna@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the notification badge UI from
NavBar.tsxinto a standaloneNotificationBadgecomponent and adds comprehensive unit tests.Changes:
src/components/NotificationBadge.tsx— New component accepting anotificationCountprop. Hides the badge when count is 0, displays the count otherwise. Preserves all existingdata-testattributes and routing behavior.src/components/NavBar.tsx— Simplified by delegating badge rendering toNotificationBadge. Removed unusedBadgeandNotificationsIconimports and thecustomBadgestyle class (now owned byNotificationBadge).src/components/__tests__/NotificationBadge.test.tsx— 7 unit tests covering:/notificationsdata-testattributes presentReview & Testing Checklist for Human
/notificationsNotes
All existing vitest tests continue to pass (9 passed, 1 skipped). No lint errors introduced.
Link to Devin session: https://app.devin.ai/sessions/165edb2d6c61433a9ad4bb0d1117d6e3
Requested by: @VedantKh
Devin Review