fix(patients): default deceased/active on patient create (COG-117) - #30
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
POST /v1/patients returned 500 (deceased NOT NULL violation): the MapStruct toEntity create mapping overwrote the entity's deceased=false / active=true defaults with null when the client omitted them. The New Patient intake form (COG-117) does not send deceased, so registration always failed. Add defaultValue mappings so create falls back to false/true when unset. Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion backend fix for the New Patients page (COG-117, frontend in demos-coghealth-ehr-web#35).
POST /v1/patientsreturned 500 whenever the client omitteddeceased:Root cause:
PatientMapper.toEntity(MapStruct) builds a new entity and callspatient.deceased(dto.getDeceased())unconditionally, overwriting the entity's@Builder.Default deceased = falsewithnull. The DB column isdeceased BOOLEAN NOT NULL DEFAULT FALSE, but the explicitnullin the generated INSERT bypasses the DB default → constraint violation. The new patient intake form does not (and should not) senddeceased, so registration always failed end-to-end.activehas the same latent issue (form happens to sendtrue).Fix — add
defaultValueto the create mapping so an unset value falls back to the entity/DB default:Generated
toEntitynow doesif (dto.getDeceased() != null) ... else patient.deceased(false)(same foractive).updateEntityFromDtois unchanged (already ignores nulls). A client that explicitly sendsdeceased/activeis still respected.Verified against a fresh Flyway-built DB:
POST /v1/patientswith the form's payload now returns 201 withdeceased:falseand the address persisted.No tests added — the repo currently has no test source tree (
src/testabsent); change verified manually end-to-end via the frontend form.Link to Devin session: https://app.devin.ai/sessions/bac7d1fcc3b542809fe47cf1a15957a2
Requested by: @tobydrinkall
Devin Review