Conversation
…n spring-web (feature) Co-Authored-By: Daniella Grimberg <daniella@cognition.ai>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates CVE-2024-22262 (GHSA-2wrp-6fg6-hmc5) —
UriComponentsBuilderURL-parsing flaw inspring-webenabling open redirect / SSRF. The vulnerablespring-web:5.3.31came transitively fromspring-boot-starter-parent:2.7.18, which is also EOL for OSS, so the fix is a full upgrade to Spring Boot 3.3.13 (latest 3.3.x GA) rather than a pin.Also closes CVE-2022-1471 (snakeyaml) via the Boot-managed snakeyaml 2.2.
Before / after
flyway-database-postgresql)springdoc-openapi-ui1.7.0springdoc-openapi-starter-webmvc-ui2.6.0java-version)Breaking changes fixed
javax.persistence/javax.validation/javax.servlet→jakarta.*across entities, DTOs, controllers, the JWT servlet filter and the legacyEntityManagerservices.javax.crypto(JDK) intentionally untouched.SecurityConfig#filterChainrewritten; authorization rules are unchanged:JwtAuthenticationFilterstays a@ComponentOncePerRequestFilter(same registration as before — not added to the chain, which would have double-registered it), stateless sessions and CORS config unchanged.flyway-database-postgresqlor startup fails with "Unsupported Database: PostgreSQL".spring.redis.*→spring.data.redis.*inapplication.yml.lombok-mapstruct-bindingannotation-processor path (ordered lombok → binding → mapstruct-processor) so generated mappers still see Lombok accessors.@Operation/OpenAPI annotations were alreadyio.swagger.v3, so no source changes.No business logic, DTO contracts, Flyway migrations, or audit-layer (
@AuditAccess,PatientAccessLogger) changes. No JPQL changes were needed — existing queries are Hibernate 6 compatible.Verification
Flyway validated the 3 existing migrations against the live schema on boot. The repo has no test sources, so
verifyruns no tests; no assertions were changed or weakened.Pre-existing behavior confirmed unchanged:
GET /api/v1/encounters/patient/{id}returns 500 (Jackson cannot serialize the Hibernate lazy proxy onEncounter.patient) — reproduced identically onmainbefore the upgrade, so it is not a regression and is left out of scope.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/4970d62b0e3a42729a24af410b7e4085
Open in Devin Desktop: https://app.devin.ai/desktop/session/4970d62b0e3a42729a24af410b7e4085?variant=devin
Requested by: @danigrim