Improve Responsive UI in TailAdmin React Dashboard - #4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Fix inconsistent breakpoint usage in AppHeader.tsx using matchMedia - Expand mobile viewport testing in Playwright tests (small phones, large phones, tablets landscape) - Improve modal responsiveness in UserInfoCard.tsx (md breakpoint for grid) - Fix table button group overflow in RecentOrders.tsx (flex-col on mobile) - Fix calendar component minimum width in index.css (responsive min-width) - Optimize touch target sizes in AppHeader.tsx (w-11 h-11 for 44px targets) Co-Authored-By: bobby.nobakht@codeium.com <bnobakht35@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Responsive UI in TailAdmin React Dashboard
Summary
This PR implements 6 responsive UI improvements across the dashboard:
AppHeader.tsx: Replaced
window.innerWidthcheck withwindow.matchMedia()for more reliable breakpoint detection that aligns with Tailwind'slg:breakpoint (1024px)AppHeader.tsx: Increased touch target size from 40px (
w-10 h-10) to 44px (w-11 h-11) to meet accessibility guidelines for mobile touch targetsUserInfoCard.tsx: Changed modal grid breakpoint from
lg:grid-cols-2tomd:grid-cols-2so the 2-column layout activates earlier on tabletsRecentOrders.tsx: Added
flex-col sm:flex-rowto button container so Filter/See All buttons stack vertically on mobile instead of causing horizontal overflowindex.css: Made FullCalendar min-width responsive (
min-w-full sm:min-w-[718px]) to prevent forced horizontal scrolling on mobiletest_playwright.py: Added viewport tests for small phones (375x667), large phones (414x896), and tablets landscape (1024x768)
Review & Testing Checklist for Human
matchMediachange doesn't break toggle functionalityRecommended test plan: Run the app locally (
npm run dev) and use browser DevTools to test at viewport widths: 375px, 414px, 768px, 1024px. Check each modified component at these breakpoints.Notes
Link to Devin run: https://app.devin.ai/sessions/00cebc5f90674310ba4779014121ed6a
Requested by: bobby.nobakht@codeium.com (@bnob-ship-it)