Skip to content

Fix: Consumer PII transits and is logged in plaintext: TLS disabled on the production datasource and SQL statement logging enabled #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WesternConcrete wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Consumer PII transits and is logged in plaintext: TLS disabled on the production datasource and SQL statement logging enabled #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84959e5
Require TLS on the ftgo datasource and stop logging SQL statements
devin-ai-integration[bot] Aug 31, 2026
6968070
Enable TLS on the bundled MySQL image and allow the sslMode to be raised
devin-ai-integration[bot] Aug 31, 2026
f7eee67
Pin the datasource sslMode instead of allowing an env override
devin-ai-integration[bot] Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ services:
depends_on:
- mysql
environment:
SPRING_DATASOURCE_URL: jdbc:mysql://mysql/ftgo
SPRING_DATASOURCE_URL: jdbc:mysql://mysql/ftgo?sslMode=REQUIRED
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
SPRING_DATASOURCE_USERNAME: mysqluser
SPRING_DATASOURCE_PASSWORD: mysqlpw
SPRING_DATASOURCE_DRIVER_CLASS_NAME: com.mysql.jdbc.Driver
Expand Down
9 changes: 5 additions & 4 deletions ftgo-application/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ spring.application.name=ftgo-application

spring.jpa.generate-ddl=false
logging.level.org.springframework.orm.jpa=INFO
logging.level.org.hibernate.SQL=DEBUG
spring.datasource.url=jdbc:mysql://${DOCKER_HOST_IP:localhost}/ftgo?useSSL=false&allowPublicKeyRetrieval=true
spring.datasource.username=mysqluser
spring.datasource.password=mysqlpw
logging.level.org.hibernate.SQL=WARN
logging.level.org.hibernate.type.descriptor.sql.BasicBinder=WARN
spring.datasource.url=jdbc:mysql://${DOCKER_HOST_IP:localhost}/ftgo?sslMode=REQUIRED
spring.datasource.username=${SPRING_DATASOURCE_USERNAME:mysqluser}
spring.datasource.password=${SPRING_DATASOURCE_PASSWORD:mysqlpw}
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
spring.datasource.driver-class-name=com.mysql.cj.jdbc.Driver
2 changes: 1 addition & 1 deletion mysql/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
FROM mysql:5.7.13
FROM mysql:5.7.44
COPY schema.sql /docker-entrypoint-initdb.d/schema.sql