Fix: Apache Tomcat Improper Input Validation vulnerability - #319
Open
WesternConcrete wants to merge 1 commit into
Open
WesternConcrete wants to merge 1 commit into
WesternConcrete wants to merge 1 commit into
Conversation
Co-Authored-By: Wes Convery <2wconvery@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finding: Apache Tomcat Improper Input Validation vulnerability (CVE-2023-46589, GHSA-fccv-jmmp-qg76)
Repo: COG-GTM/ftgo-monolith
Fix approach: override the Spring Boot 2.0.3 BOM's
tomcat.version(8.5.31, affected range 8.5.0–8.5.95) ingradle.propertiesso the embedded Tomcat resolves to 8.5.98, which contains the request-smuggling fix.tomcat.version=8.5.98Why 8.5.98 and not the latest 8.5.100: Tomcat 8.5.99+ made
StandardServer.findServices()synchronize onservicesLock, which Spring Boot 2.0.x'sTomcatWebServer.removeServiceConnectors()calls from thelocalhost-startStop-1context-start thread while the main thread holds the same lock inStandardServer.startInternal(). Verified locally: with 8.5.100 the app deadlocks during Tomcat startup (jstack shows the two threads blocked on each other); with 8.5.98 startup proceeds identically tomaster.Verification:
./gradlew :ftgo-application:dependenciesshowstomcat-embed-core/el/websocket:8.5.31 -> 8.5.98;bootJarbuilds; the runtime log reportsStarting Servlet engine: [Apache Tomcat/8.5.98]and the dispatcher servlet is mapped.Link to Devin session: https://app.devin.ai/sessions/b21209f466c34d0db5dd23c559c9f641
Open in Devin Desktop: https://app.devin.ai/desktop/session/b21209f466c34d0db5dd23c559c9f641?variant=devin
Requested by: @WesternConcrete