Fix: Deeply nested json in jackson-databind - #328
Open
WesternConcrete wants to merge 2 commits into
Open
WesternConcrete wants to merge 2 commits into
WesternConcrete wants to merge 2 commits into
Conversation
Co-Authored-By: Wes Convery <2wconvery@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Wes Convery <2wconvery@gmail.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finding: Deeply nested json in jackson-databind (CVE-2020-36518, GHSA-57j2-w4cx-62h2)
Repo: COG-GTM/ftgo-monolith
ftgo-commonpinnedjackson-databind2.9.7 (shared by every REST module); no 2.9.x release limits JSON nesting depth, so a deeply nested request body causes aStackOverflowError(unauthenticated DoS).Fix approach: move all Jackson modules to 2.17.3 — the explicit
jackson-core/jackson-databind/jackson-datatype-jsr310pins inftgo-common/build.gradle, plusext['jackson.version'] = '2.17.3'in the rootsubprojects {}block so the Spring Boot dependency-management BOM resolves the transitive Jackson modules (annotations, jdk8, parameter-names) at the same version instead of 2.9.6. 2.17.3 was chosen over 2.13.x so that jackson-core is also past CVE-2025-52999 (fixed in 2.15.0), which the Snyk PR check flagged on the first revision.Note: local Gradle build could not be verified in this session because Maven Central returned HTTP 429 (rate limited) for all artifact downloads; relying on CI.
Link to Devin session: https://app.devin.ai/sessions/2aa54ffd887c442a8c8a716040545202
Open in Devin Desktop: https://app.devin.ai/desktop/session/2aa54ffd887c442a8c8a716040545202?variant=devin
Requested by: @WesternConcrete