fix: extract constant for duplicated GQL client error string (go:S1192) - #140
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Define errFailedToGetGQLClient constant to replace 4 duplicated occurrences of "failed to get GitHub GQL client: %v" in discussions.go, resolving SonarQube go:S1192 (CRITICAL). Co-Authored-By: Eashan Sinha <eashan.sinha@cognition.ai>
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SonarQube issue
AZhX1hJ3UiHWiWeaJF-T(rulego:S1192— duplicated string literals, CRITICAL).What
Defines an unexported constant
errFailedToGetGQLClientfor the string"failed to get GitHub GQL client: %v", which was duplicated 4 times acrossListDiscussions,GetDiscussion,GetDiscussionComments, andListDiscussionCategoriesinpkg/github/discussions.go.Why
SonarQube flagged this as a CRITICAL maintainability issue — duplicated string literals make refactoring error-prone since changes must be propagated to every occurrence.
Review checklist
err-prefixed)pkg/github/duplicate this same literal (this PR only addressesdiscussions.goper the SonarQube finding)Link to Devin session: https://app.devin.ai/sessions/64c1809b174b44f4a6b5f6ef99e66434
Requested by: @eashansinha