Fix SonarQube S1192 and S3776 issues in pkg/github/notifications.go

[eashansinha]

Closes: N/A (SonarQube remediation)

Summary

Fixes high-severity SonarQube issues in pkg/github/notifications.go:

S1192 — duplicated string literals replaced with package-level constants:

• paramOwner, paramRepo, paramAction, paramNotificationID for repeated parameter names
• errFailedToReadBodyFmt for the 4x-repeated "failed to read response body: %w" format string
• errInvalidActionMessage, descRepositoryOwner, descRepositoryName

S3776 — cognitive complexity of the ListNotifications handler reduced by extracting:

• parseListNotificationsParams(request) — extracts/validates the six optional params into a listNotificationsParams struct
• buildNotificationListOptions(params) — builds github.NotificationListOptions including RFC3339 parsing of since/before

No behavior changes; error messages and tool schemas are identical.

Verification

• go build ./..., go vet ./..., gofmt clean
• go test ./pkg/github/ passes

Link to Devin session: https://app.devin.ai/sessions/1db4c7c8dff14301acfe40dde84da912
Requested by: @eashansinha

---

Devin Review

Status	Commit
🟢 Reviewed	fe58c75

[devin-ai-integration]

Original prompt from Eashan

Fix the following high severity SonarQube issues in @COG-GTM/github-mcp-server :
Repository: COG-GTM/github-mcp-server File: pkg/github/notifications.go Issues (8 total):

Fix these issues by:
For S1192 (duplicated strings): Define constants at the package level for repeated string literals
For S3776 (cognitive complexity): Refactor complex methods by extracting helper functions
Run tests after fixes to ensure nothing breaks.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[staging-devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Debug

Playground

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.