Bump Go to 1.25.13 to clear 13 HIGH stdlib CVEs - #157
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: shayan <shayan@cognition.ai>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Closes:
All HIGH Snyk findings in this repo were Go standard-library CVEs attributed to the
go 1.23.7directive. Bumping thegodirective to1.25.13(the latest 1.25 patch, a fixed release for every one of them) and the Docker build stage fromgolang:1.24.4-alpinetogolang:1.26.6-alpineclears them all.The toolchain bump forced two follow-on changes, both required to keep CI green:
golangci-lintpinv2.1→v2.12.2: v2.1 is built with Go 1.24 and refuses to run against a go.mod targeting 1.25 (the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.13)). Every release built with Go ≤ 1.25 also panics when analyzing packages compiled by Go 1.26 (whichgo-version: stableinstalls), so v2.12.2 (built with go1.26.2) is the first workable pin.reflect.Ptr→reflect.Pointer(govet inline),WriteString(fmt.Sprintf(...))→fmt.Fprintf(...)(staticcheck QF1012, 3x), and#nosecannotations for gosec's new G703 (doc generator writing to a path from a CLI flag — same lines already carry#nosec G304/G306) and G117 (json.Marshalof secret-scanning alerts, which is exactly what those tools exist to return).Snyk IDs fixed (13 unique HIGH)
Before / after (
snyk test --all-projects, Snyk CLI 1.1306.4)Intentionally left unfixed
SNYK-GOLANG-GITHUBCOMGOVIPERMAPSTRUCTUREV2-12177854(medium,go-viper/mapstructure/v22.3.0 → 2.4.0, transitive viaspf13/viper) — medium severity, out of scope for this pass.go 1.25.13rather than1.26.xfor thegodirective to avoid forcing consumers onto the newest major line; every HIGH finding has a 1.25.x fixed release. The Docker builder image uses 1.26.6 (latest stable), which satisfies the directive.Verification
On go1.26.6:
go build ./...,go test ./...,golangci-lint v2.12.2 run(0 issues), andgenerate-docsproduces no diff. A freshsnyk testreports zero high/critical findings.Link to Devin session: https://app.devin.ai/sessions/862ec2de1ef042cd8147bf73f4a0b348
Requested by: @shayanshafii
Devin Review