Bump Go to 1.25.14 to clear stdlib high-severity advisories - #158
Open
devin-ai-integration[bot] wants to merge 4 commits into
Open
devin-ai-integration[bot] wants to merge 4 commits into
devin-ai-integration[bot] wants to merge 4 commits into
Conversation
Co-Authored-By: shayan <shayan@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: shayan <shayan@cognition.ai>
Co-Authored-By: shayan <shayan@cognition.ai>
Co-Authored-By: shayan <shayan@cognition.ai>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes:
Summary
Snyk flagged 13 unique high-severity findings, all attributed to the Go standard library pinned by
go.modat 1.23.7 (std/net/http,std/net/url,std/os,std/net,std/crypto/x509,std/mime). No application code changes — version bumps only.go.mod:go 1.23.7→go 1.25.14(latest 1.25 patch; >= 1.25.13 clears all listed advisories). Staying on the 1.24 line would leave several of them open, so 1.25.14 was chosen.Dockerfile: builder imagegolang:1.24.4-alpine→golang:1.25.14-alpine.github/workflows/lint.yml: golangci-lintv2.1→v2.5and the lint job's Go now comes fromgo-version-file: "go.mod"instead ofstable. Both are required by the bump: golangci-lint v2.1 is built with Go 1.24 and refuses a 1.25 target outright, and v2.5 (built with Go 1.25) panics while type-checking against thestable(1.27) toolchain's stdlib. The action is also pinned to its v8 commit SHA to satisfy the Sonar quality gate, which counts the touched line as new code.No other workflow needed changes — they all already resolve Go from
go.mod.Verification
go build ./...,go test ./...,golangci-lint run(v2.5.0 on Go 1.25.14) — all clean locallydocker build .— succeeds on the new builder imagesnyk test --all-projects --severity-threshold=high— "Tested 125 dependencies for known issues, no vulnerable paths found."Analyze (go)/Analyze (actions)failures are a pre-existing org configuration problem unrelated to this change (Error getting package versions 'github/ccr-go-queries' ... 403 permission_denied), and reproduce on other branches. TheDockerworkflow job sits queued with no runner, as on other recent branches.Link to Devin session: https://app.devin.ai/sessions/3b098a7759be4081a54f2b5f5196371c
Requested by: @shayanshafii
Devin Review