bug: restrict User attributes exposed by GET /rest/memories - #336
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Signed-off-by: Devin <devin@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GET /rest/memories(unauthenticated) returned each memory with the fully-serialized associatedUserrow, exposingpassword(MD5 hash),totpSecret,deluxeToken,emailandlastLoginIpof every user who uploaded a memory.getMemories()now includesUserModelwithattributes: ['id', 'username']— the only field the photo wall frontend consumes (memory.User?.username). An API test asserts the serializedUserobject contains exactly those keys.Resolved or fixed issue: none
AI Tool Disclosure
DevinDevin (Cognition AI)Fix security finding: unauthenticated GET /rest/memories exposes all users' credentials via unrestricted UserModel includeAffirmation
Devin-Org: engineering