feat(infra): PR #7 — Terraform ECS compute + autoscaling - #178
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…nfra/compute) (feature) PR #7 / Wave 2: self-contained Terraform root infra/compute - ECS Fargate cluster, per-program task definition (EFS volume for AWS.M2.CARDDEMO.* datasets, container health check hitting the /health sidecar, awslogs) and service, IAM execution/task roles (ECR pull, logs, EFS client access), and target-tracking autoscaling (CPU always-on; optional SQS queue-depth backlog-per-task). Parameterized by var.programs and consumes network/storage outputs. Validates offline. Co-Authored-By: Vibha Seshadri <vibha.seshadri@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 2 / PR #7. Self-contained Terraform root
infra/compute/running the GnuCOBOL batch/service containers on ECS Fargate with health checks and target-tracking autoscaling. Consumesinfra/network(subnets, SG) andinfra/storage(EFS id/access point) outputs via variables; parameterized byvar.programsso onboarding a service is config-only.Key points hard to see from the diff:
python3 urllib(already in the image — no curl needed) so ECS marks a task unhealthy when/healthreturns 503, which the entrypoint sets on program failure.MODE=serviceso the container stays up for the service/autoscaling model (vsoneshotbatch).local.imagesfalls back to a placeholder ECR URL whenecr_repository_urlsis empty, so the root plans/validates offline before Add User ID alphanumeric validation for MBA-123 #5 outputs are wired.Verified locally
terraform fmt,terraform init -backend=false,terraform validate→ Success! The configuration is valid.Links
docs/modernization/CURRENT_STATE_ANALYSIS.md§6 (no autoscaling/health today)Link to Devin session: https://app.devin.ai/sessions/c0f261ce337a4aee965332f1754d037a
Requested by: @vibhaseshadri-cognition
Devin Review